Updated concat.py to add defaults for missing variables
#2
Open
fumedev[bot] wants to merge 1 commit intotest2from
Open
Updated concat.py to add defaults for missing variables
#2fumedev[bot] wants to merge 1 commit intotest2from
concat.py to add defaults for missing variables
#2fumedev[bot] wants to merge 1 commit intotest2from
Conversation
…r missing variables in `xarray.concat`; added new tests and updated documentation"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGED
Updated the
_calc_concat_overmethod inconcat.pyto now calculate which variables need to be concatenated and add any missing variables withnp.nanvalues for datasets that do not contain them.Added new test cases in
test_concat.pyto cover edge cases such as pre-existing vs non-pre-existing dimensions, different dimension sizes, missing variables, and extra dimensions. Ensured critical scenarios are covered for concatenation with the addition of defaults.Updated
whats-new.rstto include a new entry specifying the enhancement thatxarray.concatnow supports concatenating datasets with disjoint variables. The feature fills missing variables withnp.nanby default, providing an example for user clarity.