Updated Dataset Arithmetic Methods to Support 'keep_attrs' Option#3
Open
fumedev[bot] wants to merge 1 commit intotest3from
Open
Updated Dataset Arithmetic Methods to Support 'keep_attrs' Option#3fumedev[bot] wants to merge 1 commit intotest3from
fumedev[bot] wants to merge 1 commit intotest3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGED
_binary_opmethod inxarray/core/dataset.pyto incorporate logic for handling thekeep_attrsoption. The method now includes checks forkeep_attrsand preserves attributes accordingly during binary operations withDatasetobjects.Datasetclass, such as__add__and__sub__, to accept akeep_attrsparameter which is passed through to the_binary_opmethod. This enhancement allows end-users to control attribute preservation on a per-operation basis.xarray/tests/test_dataset.pyto verify the functionality ofkeep_attrsduring binary operations withDatasetobjects. These tests ensure that attributes are preserved as expected when performing arithmetic operations on datasets.