Implemented non-dimensional coordinate preservation in Coarsen class#4
Open
fumedev[bot] wants to merge 1 commit intotest5from
Open
Implemented non-dimensional coordinate preservation in Coarsen class#4fumedev[bot] wants to merge 1 commit intotest5from
fumedev[bot] wants to merge 1 commit intotest5from
Conversation
Updated rolling functionality and tested ensuring non-dim coords as coordinates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGED
Modified the
Coarsenclass in the xarray/core/rolling.py file to ensure that non-dimensional coordinates remain as coordinates after applying the_constructmethod. The changes include creating a new DataArray with windowed dims, applying indexing specified by stride while preserving original coords, and re-attaching original non-dim coords after applying isel.Ensured that the high-level
constructmethod withinDataArrayCoarsennow properly delegates to the modified_constructmethod to maintain consistency.ADDED
test_nondimensional_coordsto verify that non-dimensional coordinates remain as coordinates following the use ofconstructon aCoarsenobject. The test covers various non-dimensional coordinate values and compares them against expected values usingpytest's parameterize feature.Note: The actual code for the unit test is not provided, but the test case has been created and should be implemented as per development best practices.