Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GERG-2008-H2 Model with Improved Hydrogen Parameters
Summary
Implements the GERG-2008-H2 equation of state extension with improved hydrogen binary interaction parameters based on Beckmüller et al. (2022).
Changes
GERG2008H2class - ExtendsGERG2008with updated hydrogen parameters for CH₄-H₂, N₂-H₂, CO₂-H₂, and other binariesGERG2008Typeenum -STANDARDandHYDROGEN_ENHANCEDmodel selectionSystemGERG2008Eos- AddeduseHydrogenEnhancedModel()andsetGergModelType()methodsNeqSimGERG2008- Constructor accepts model type parameterdocs/thermo/gerg2008_eoscg.mdUsage
Key Differences from GERG-2008
Reference
Beckmüller, R. et al. (2022). "Extension of the equation of state for natural gases GERG-2008 with improved hydrogen parameters". Fluid Phase Equilibria, 557, 113411.