Conversation
- DatabaseTorgDataSource.loadFromLegacyTable: added @param/@return - ProcessDerivativeCalculator: added docs for 5 methods (calculateJacobianSequential, calculateJacobianParallel, calculateForwardDifference, calculateCentralDifference, perturbAndEvaluate) - ProcessVariableAccessor.matchesParams: added @param/@return - IntegratedSafetySystemExample.runScenario4_PSVRelief: added all @param tags
- TechnicalRequirements_Process.csv: Add 93 new rows for design parameters - Separator: pressure margins, foam allowance, droplet diameters, demister specs - Heat exchanger: fouling resistance, TEMA classification, velocity limits - Compressor: surge margin, turndown, efficiency targets, vibration limits - Pump: NPSH margin, BEP region, max speed - Valve: Cv margin, velocity limits - Vessel: L/D ratio, joint efficiency, nozzle velocity - Cooler, flare system, PSV parameters - ProcessDesignStandard.java: New class for process design calculations - Design pressure/temperature margin calculations - Design flow rate with turndown consideration - Design duty and area calculations - Database parameter loading by equipment type - SeparatorMechanicalDesign.java: Process design enhancements - Foam allowance factor and droplet diameter fields - Demister/mist eliminator parameters - Stokes and Souders-Brown velocity calculations - Database loading for process design parameters - HeatExchangerMechanicalDesign.java: TEMA and fouling enhancements - Fouling resistance for shell/tube water/HC services - TEMA classification (class, shell type, head types) - Tube bundle parameters (diameter, thickness, pitch, layout) - Velocity limits and baffle parameters - CompressorMechanicalDesign.java: Operating range enhancements - Surge/stonewall margin tracking - Turndown and efficiency requirements - Seal and bearing type specifications - NACE compliance flag
…sign classes - Add validation methods to Separator, HeatExchanger, Compressor, and Pump designs - Add process design parameters to Response classes for JSON export - Create comprehensive unit tests for validation methods (55 tests pass) - Support industry standards: API-610, API-617, TEMA, API-12J/NORSOK-P-001 Parameters added: - Separator: foam allowance, droplet diameters, demister specs, velocity limits - HeatExchanger: fouling resistances, TEMA class, velocity limits, approach temp - Compressor: surge/stonewall margins, turndown, efficiency targets - Pump: NPSH margin, POR/AOR fractions, suction specific speed
…hods - Add Process Design Parameters section to mechanical_design.md - Separator: foam allowance, droplet diameters, demister specs, velocity limits - Compressor: surge/stonewall margins, turndown, efficiency targets, seal/bearing types - Pump: NPSH margin, POR/AOR fractions, suction specific speed (API-610) - Heat Exchanger: fouling resistances, TEMA class, velocity limits (TEMA) - Add Design Validation section with validation result classes - Individual parameter validation methods - Comprehensive validation with issue reporting - Examples for all equipment types - Update EQUIPMENT_DESIGN_PARAMETERS.md with validation methods section - Update REFERENCE_MANUAL_INDEX.md with new documentation references
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to NeqSim! Please complete the following checklist before requesting review:
./mvnw testruns successfullySee CONTRIBUTING.md for the full contribution process.