Skip to content

ui: named arguments, click-to-source, and call stack params#198

Merged
gnidan merged 1 commit intocall-returnfrom
ui-rich-context-display
Apr 1, 2026
Merged

ui: named arguments, click-to-source, and call stack params#198
gnidan merged 1 commit intocall-returnfrom
ui-rich-context-display

Conversation

@gnidan
Copy link
Copy Markdown
Member

@gnidan gnidan commented Apr 1, 2026

Summary

  • Show named argument parameters in invoke labels: "invoke add(a, b)" instead of "invoke add", in BytecodeView, call stack breadcrumbs, and call info banners
  • Add click-to-source on invoke/return/revert badges in BytecodeView — fires onDeclarationClick with source ID, offset, and length from the declaration field
  • Extract argumentNames and declaration from invoke/return/revert contexts via summarizeContext, formatCallSignature, and DeclarationRange type
  • Updated across bugc-react, programs-react, and web TraceDrawer

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-04-01 21:14 UTC

Show named argument parameters throughout the UI:

- BytecodeView labels show "invoke add(a, b)" instead of
  "invoke add" when argument names are available in the
  invoke context's pointer group entries
- Call stack breadcrumbs show "add(a, b)" instead of "add()"
  in both programs-react CallStackDisplay and web TraceDrawer
- CallInfoPanel banner shows "Calling add(a, b)"

Add click-to-source for context badges:

- BytecodeView accepts onDeclarationClick callback
- Clicking an invoke/return/revert badge with a declaration
  field fires the callback with sourceId, offset, and length
- Falls back to pinning the tooltip if no declaration

Extract declaration and argument names from contexts:

- summarizeContext now returns argumentNames and declaration
- New formatCallSignature utility for consistent formatting
- New DeclarationRange type for click-to-source data
- CallFrame and CallInfo types carry argumentNames
@gnidan gnidan force-pushed the ui-rich-context-display branch from e484fee to 25b47d2 Compare April 1, 2026 21:05
@gnidan gnidan merged commit ff8ebcb into call-return Apr 1, 2026
4 checks passed
@gnidan gnidan deleted the ui-rich-context-display branch April 1, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant