bugc: fix multi-block function return values#200
Merged
gnidan merged 1 commit intocall-returnfrom Apr 2, 2026
Merged
Conversation
Functions with if/else branches returning from both sides produced wrong return values. The branch terminator's loadValue(condition) DUPs the condition onto the stack; JUMPI consumes the dup but the original remains. Successor blocks inherit this stale value, so the return epilogue incorrectly treated it as the return value. Add generateReturnEpilogue that loads the return value, cleans stale stack entries via SWAP+POP, then loads the saved return PC and jumps back. Uses the same imperative state pattern as generateCallTerminator. Also changes generateTerminator return type from Transition<S, S> to Transition<S, Stack> to accommodate the stack-cleaning epilogue.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateReturnEpiloguethat loads return value, cleans stale stack via SWAP+POP, loads saved return PC, and jumps back (same imperative pattern asgenerateCallTerminator)