update plotly.js#1
Merged
eventdriventech merged 172 commits intoeventdriventech:masterfrom Sep 21, 2016
Merged
Conversation
- which were removed from the API on 0.22.0 - replace with map.addSource and map.getSource().setData()
Fix register call in gl2d test suite
Bump mapbox-gl to v0.22.0
Fix range selector position logic for overlaying axes
- this move will allow us to test (with jasmine spies) that the proper subroutines are called.
- split flag-finding logic with plot-routine sequence building
- in a similar way to Plotly.restyle
- reuse flag-finding methods called in restyle & relayout - combine flags into subroutine sequences
- testing that the correct subroutines are called.
Heatmap Padding
Merge 1.16.3 book-keeping into master
Fixup cartesian dragbox module
make paper bgcolor relayout update legend and updatemenu accordingly
- this was only violated once in drawing (fixed in this commit)
- exclude MathJax.<> calls - exclude in micropolar module
The code was comparing the result of `typeof` with a variable named `undefined`. As typeof returns a string it should compare to `'undefined'`
New eslint rules
Correct check for undefined variable
Drop docker-compose
- gl-pointcloud2d will still use [email protected], but every other module will use 4.2.0
Lock gl-shader to 4.2.0
Mirror events on an internal event handler
Emit plotly_animatingframe event on animated frames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your interest in plotly.js!
Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.
Before opening a pull request, developer should:
git rebasetheir local branch off the latestmastergit addthedist/folder (thedist/is updated only on verion bumps)Note that it is forbidden to force push (i.e.
git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, pleasegit merge masterinto your PR branch instead ofgit rebase master.