fix: header signature cleanup by facundomedica · Pull Request #2164 · evstack/ev-node

facundomedica · 2025-04-10T10:47:19Z

Overview

Previously the header signature verification was failing given that different sign bytes were being used. Some cleanup was done too, like using signer.Signer in the header and removing types.Signer.

Also GetAddress() was added to signer.Signer.

coderabbitai · 2025-04-10T10:47:27Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-04-10T10:51:07Z

Codecov Report

Attention: Patch coverage is 25.67568% with 55 lines in your changes missing coverage. Please review.

Project coverage is 26.79%. Comparing base (a45bb29) to head (05ee30a).
Report is 1 commits behind head on feature/exec_api.

Files with missing lines	Patch %	Lines
block/manager.go	0.00%	30 Missing ⚠️
pkg/signer/file/local.go	0.00%	12 Missing ⚠️
pkg/signer/noop/signer.go	50.00%	8 Missing and 3 partials ⚠️
types/utils.go	71.42%	2 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##           feature/exec_api    #2164      +/-   ##
====================================================
- Coverage             27.11%   26.79%   -0.32%     
====================================================
  Files                    59       59              
  Lines                  6790     6803      +13     
====================================================
- Hits                   1841     1823      -18     
- Misses                 4751     4781      +30     
- Partials                198      199       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

types/serialization.go

block/manager.go

types/serialization.go

types/signed_header.go

tac0turtle

left some comments, this seems incorrect or im missing something

pkg/signer/noop/signer.go

tac0turtle

i think we can remove the noop changes for getAddress, otherwise nice cleanup. Should we add a verification test to make sure it works.

fix: header signature cleanup

792dd13

github-project-automation bot added this to Evolve Apr 10, 2025

lint fix

e58d968

github-actions bot assigned facundomedica Apr 10, 2025

RollkitBot requested review from a team, MSevey, gupadhyaya and yarikbratashchuk and removed request for a team April 10, 2025 10:47

tac0turtle reviewed Apr 10, 2025

View reviewed changes

types/serialization.go Outdated Show resolved Hide resolved

block/manager.go Outdated Show resolved Hide resolved

block/manager.go Outdated Show resolved Hide resolved

types/serialization.go Outdated Show resolved Hide resolved

types/signed_header.go Outdated Show resolved Hide resolved

tac0turtle reviewed Apr 10, 2025

View reviewed changes

facundomedica added 3 commits April 10, 2025 17:08

rollback

bd0b23d

lint

2758890

slightly better error handling

3cac8a3

tac0turtle reviewed Apr 10, 2025

View reviewed changes

pkg/signer/noop/signer.go Show resolved Hide resolved

tac0turtle approved these changes Apr 10, 2025

View reviewed changes

Merge branch 'feature/exec_api' into facu/cleanup-sigs

05ee30a

tac0turtle merged commit 845a307 into feature/exec_api Apr 11, 2025
21 of 25 checks passed

tac0turtle deleted the facu/cleanup-sigs branch April 11, 2025 09:18

github-project-automation bot moved this to Done in Evolve Apr 11, 2025

tac0turtle removed this from Evolve Apr 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: header signature cleanup#2164

fix: header signature cleanup#2164
tac0turtle merged 6 commits intofeature/exec_apifrom
facu/cleanup-sigs

facundomedica commented Apr 10, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 10, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Apr 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tac0turtle left a comment

Uh oh!

Uh oh!

tac0turtle left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

facundomedica commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Uh oh!

coderabbitai bot commented Apr 10, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tac0turtle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tac0turtle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

facundomedica commented Apr 10, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Apr 10, 2025 •

edited

Loading