Skip to content

refactor: simplify config handling#2165

Merged
julienrbrt merged 15 commits intoevstack:feature/exec_apifrom
julienrbrt:julien/simplify-config
Apr 11, 2025
Merged

refactor: simplify config handling#2165
julienrbrt merged 15 commits intoevstack:feature/exec_apifrom
julienrbrt:julien/simplify-config

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Apr 10, 2025

Simplify further the config handling.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 10, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@julienrbrt julienrbrt marked this pull request as ready for review April 10, 2025 15:57
@RollkitBot RollkitBot requested review from a team, MSevey, gupadhyaya and yarikbratashchuk and removed request for a team April 10, 2025 15:58
@julienrbrt julienrbrt marked this pull request as draft April 10, 2025 15:59
@julienrbrt julienrbrt marked this pull request as ready for review April 10, 2025 18:42
@RollkitBot RollkitBot requested a review from a team April 10, 2025 18:42
@julienrbrt julienrbrt requested review from randygrok and tac0turtle and removed request for a team April 10, 2025 18:42
tac0turtle
tac0turtle reviewed Apr 10, 2025
View reviewed changes
tac0turtle
tac0turtle approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove the shell script otherwise nice clean up

@codecov
Copy link

codecov bot commented Apr 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.65766% with 47 lines in your changes missing coverage. Please review.

Project coverage is 26.19%. Comparing base (a45bb29) to head (c07aea4).
Report is 2 commits behind head on feature/exec_api.

Files with missing lines Patch % Lines
pkg/config/config.go 60.81% 18 Missing and 11 partials ⚠️
pkg/cmd/init.go 41.66% 3 Missing and 4 partials ⚠️
pkg/config/yaml.go 53.84% 5 Missing and 1 partial ⚠️
pkg/cmd/run_node.go 33.33% 3 Missing and 1 partial ⚠️
pkg/cmd/p2p.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                  @@
##           feature/exec_api    #2165      +/-   ##
====================================================
- Coverage             27.11%   26.19%   -0.92%     
====================================================
  Files                    59       59              
  Lines                  6790     6669     -121     
====================================================
- Hits                   1841     1747      -94     
+ Misses                 4751     4727      -24     
+ Partials                198      195       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julienrbrt julienrbrt merged commit de183ff into evstack:feature/exec_api Apr 11, 2025
22 of 25 checks passed
@github-project-automation github-project-automation bot moved this to Done in Evolve Apr 11, 2025
@julienrbrt julienrbrt deleted the julien/simplify-config branch April 11, 2025 09:30
@tac0turtle tac0turtle removed this from Evolve Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@yarikbratashchuk yarikbratashchuk Awaiting requested review from yarikbratashchuk

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya

@MSevey MSevey Awaiting requested review from MSevey

@randygrok randygrok Awaiting requested review from randygrok

Assignees

@julienrbrt julienrbrt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@julienrbrt @tac0turtle