This repository was archived by the owner on Jun 11, 2019. It is now read-only.
Merged
Conversation
added 8 commits
March 31, 2016 12:42
move from .gemfile to Gemfile add metadata.json
use gemfile from puppet-network pin rake and rapes on ruby 1.8 add matcher for OpenIndiana
this willallow ruby 1.8 tests
metadata.json
Outdated
| "version_requirement": ">= 2.0.0" | ||
| }, | ||
| { | ||
| "name": "example42/firewall", |
Member
There was a problem hiding this comment.
Remove monitor, firewall and iptables modules from requirements, we don't want their dependency chain and these are needed only for optional features
Contributor
Author
There was a problem hiding this comment.
Should we do so for all other modules as well?
Member
There was a problem hiding this comment.
Yes, actually the script used for pushing modules to the forge https://github.com/example42/Example42-tools/blob/master/publish.sh did that already. But it's better to remove them everywhere, or better, leave them commented, specifying they are optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verified on Solaris 10, 11 and OpenIndiana