binary-search: Update the tests following the canonical data#1050
Closed
elyssonmr wants to merge 2 commits intoexercism:masterfrom
elyssonmr:binary-search_update
Closed
binary-search: Update the tests following the canonical data#1050elyssonmr wants to merge 2 commits intoexercism:masterfrom elyssonmr:binary-search_update
elyssonmr wants to merge 2 commits intoexercism:masterfrom
elyssonmr:binary-search_update
Conversation
Contributor
|
@elyssonmr Thanks for your pull request! Travis-CI build failed due to code style violations: $ flake8
./exercises/binary-search/binary_search_test.py:6:1: E302 expected 2 blank lines, found 1 |
Contributor
Author
|
OK, going to check as soon as I arrive home |
Contributor
Author
|
@cmccandless Done. |
Contributor
|
Hi @elyssonmr, thanks for your work on this. Unfortunately there was already an open PR for the same issue (#1024) - it was poorly named and didn't reference the corresponding issue, so I'm not surprised that you didn't see it. Since I have now merged the other PR, I'm going to go ahead and close this one, but thank you for your effort with this. |
Contributor
Author
|
No, prob I saw the notification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
binary-searchtrack following the recommendations from issue #989