Closed
Conversation
Member
|
I'd suggest incrementing the version to 1.7.1-SNAPSHOT. According to semver sorting rules, 1.7.0-SNAPSHOT < 1.7. The new development and release versions should be >1.7, even if the code hasn't changed—if only to reflect the change in organization and commitment to semver, use of central maven repositories, etc. |
Author
|
as @adamretter already started cleaning up the repo this PR can be closed. Thanks you @adamretter |
Member
Member
|
The semantic versioning was also mentioned previously - #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed pom.xml to 1.7.0-SNAPSHOT in preparation to release a version 1.7.0 which never got release afaik. I'm perfectly fine with another version number as well but 1.7 is certainly not the one we want to start of with.