[ios][ui] Add scrollTargetBehavior and scrollTargetLayout modifiers#43955
Merged
intergalacticspacehighway merged 1 commit intoexpo:mainfrom Apr 6, 2026
Merged
Conversation
Contributor
|
Subscribed to pull request
Generated by CodeMention |
35aefec to
fe50c1c
Compare
amandeepmittal
requested changes
Mar 18, 2026
Member
amandeepmittal
left a comment
There was a problem hiding this comment.
Thank you for adding docs. Left some minor suggestions.
Also, let's wait for the technical review.
fe50c1c to
0954ff8
Compare
0954ff8 to
c47a2ec
Compare
Contributor
Author
|
Mind taking a look when you get a chance @intergalacticspacehighway? |
Contributor
|
@ramonclaudio thanks for the PR, sorry for the delay. can |
c47a2ec to
85da2b6
Compare
fe89c0b to
c3f229a
Compare
cc0f7d8 to
cf1484b
Compare
Contributor
Author
|
@intergalacticspacehighway no worries. I converted scrollTargetLayout from a prop to a modifier and stripped out all scroll position state/callbacks (onScrollPositionChange, scrollToID, scrollToEdge, scrollToPoint, id()). Happy to rebase the scroll position tracking onto main once the worklet chain lands. |
cf1484b to
c095722
Compare
intergalacticspacehighway
approved these changes
Apr 6, 2026
amandeepmittal
approved these changes
Apr 6, 2026
Member
amandeepmittal
left a comment
There was a problem hiding this comment.
Docs changes lg!
@intergalacticspacehighway are we planning to publish this for SDK 55?
Contributor
yeah, will be shipped with 55! |
intergalacticspacehighway
pushed a commit
that referenced
this pull request
Apr 6, 2026
…43955) ## Why Split from the larger scroll position tracking PR per @intergalacticspacehighway feedback. Scroll position state and callbacks (`onScrollPositionChange`, `scrollToID`, `id()`) are deferred pending worklet callback support (#44214). `scrollTargetLayout` was converted from a VStack/HStack prop to a modifier, matching SwiftUI's API surface. ## What - `scrollTargetBehavior()` modifier: `paging` or `viewAligned` scroll snapping - `scrollTargetLayout()` modifier: marks a stack as a scroll target layout - `ScrollTargetBehaviorModifier.swift`, `ScrollTargetLayoutModifier.swift` registered in `ViewModifierRegistry` - TS exports in `modifiers/index.ts` with `BuiltInModifier` union entries ```tsx <ScrollView modifiers={[scrollTargetBehavior('paging')]}> <VStack modifiers={[scrollTargetLayout()]}> {items.map(item => ( <Text key={item.id}>{item.text}</Text> ))} </VStack> </ScrollView> ``` ## Test plan - `yarn build` passes - `npx tsc --noEmit` passes - `yarn test` passes (42/42) - `yarn lint --fix` passes (0 errors, 0 warnings) - Swift compiles (ExpoUI target) - Both modifiers have `#available(iOS 17.0, tvOS 17.0, macOS 14.0, *)` guards
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Split from the larger scroll position tracking PR per @intergalacticspacehighway feedback. Scroll position state and callbacks (
onScrollPositionChange,scrollToID,id()) are deferred pending worklet callback support (#44214).scrollTargetLayoutwas converted from a VStack/HStack prop to a modifier, matching SwiftUI's API surface.What
scrollTargetBehavior()modifier:pagingorviewAlignedscroll snappingscrollTargetLayout()modifier: marks a stack as a scroll target layoutScrollTargetBehaviorModifier.swift,ScrollTargetLayoutModifier.swiftregistered inViewModifierRegistrymodifiers/index.tswithBuiltInModifierunion entriesTest plan
yarn buildpassesnpx tsc --noEmitpassesyarn testpasses (42/42)yarn lint --fixpasses (0 errors, 0 warnings)#available(iOS 17.0, tvOS 17.0, macOS 14.0, *)guards