Modify Task class constructor to also take "parallel" and "serial" argument#1215
Closed
Kami wants to merge 3366 commits intofabric:masterfrom
Closed
Modify Task class constructor to also take "parallel" and "serial" argument#1215Kami wants to merge 3366 commits intofabric:masterfrom
Kami wants to merge 3366 commits intofabric:masterfrom
Conversation
Conflicts: docs/changelog.rst
Conflicts: docs/changelog.rst
Conflicts: fabric/version.py
This makes adds the 'command' attribute to local()'s return, as in run() and sudo() to make the initial command accessible after execution.
Conflicts: sites/www/changelog.rst
constructor. Also update the constructor signature so it doesn't simply quietly swallows other args and kwargs you pass in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you want to control a value of a
serialandparallelattribute on theTaskobject, you need to manually set it on the instance instead of passing it to the constructor.This branch allows you to pass those two arguments to the
Taskclass constructor. For backward compatibility reasons, they default to the same value as the values read in therequires_parallelmethod.On top of that, I also removed
*args, **kwargsfrom the method signature. Previously, the constructor would quietly swallow and ignore other unsupported args and kwargs you pass in (this makes for a bad API and developer experience).