Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

0.10.4#1449

Closed
flarnie wants to merge 2 commits intofacebookarchive:masterfrom
flarnie:prepForv0.10.4
Closed

0.10.4#1449
flarnie wants to merge 2 commits intofacebookarchive:masterfrom
flarnie:prepForv0.10.4

Conversation

@flarnie
Copy link
Copy Markdown
Contributor

@flarnie flarnie commented Oct 24, 2017

No description provided.

@flarnie flarnie added this to the v0.10.4 milestone Oct 24, 2017
@flarnie flarnie requested a review from sophiebits October 24, 2017 03:46
Comment thread CHANGELOG.md Outdated
events when right or left arrow is pressed.
([@eessex](https://github.com/eessex)
in [#1384](https://github.com/facebook/draft-js/pull/1384))
* Expose path to Draft.css for usage by CSS pre-processors.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we say more like: "Expose Draft.css as default CSS export in package.json for use by CSS preprocessors"? "Expose path" doesn't quite capture it especially since the whole point is for users to not think about the path.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

Sounds good - will fix.

Copy link
Copy Markdown

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flarnie is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Copy Markdown

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

midas19910709 added a commit to midas19910709/draft-js that referenced this pull request Mar 30, 2022
Summary: Closes facebookarchive/draft-js#1449

Differential Revision: D6133346

fbshipit-source-id: ded420cbd4d7ce1bdb85425d6151814fc3d2f226
alicayan008 pushed a commit to alicayan008/draft-js that referenced this pull request Jul 4, 2023
Summary: Closes facebookarchive/draft-js#1449

Differential Revision: D6133346

fbshipit-source-id: ded420cbd4d7ce1bdb85425d6151814fc3d2f226
aforismesen added a commit to aforismesen/draft-js that referenced this pull request Jul 12, 2024
Summary: Closes facebookarchive/draft-js#1449

Differential Revision: D6133346

fbshipit-source-id: ded420cbd4d7ce1bdb85425d6151814fc3d2f226
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants