Open
Conversation
efantinatti
suggested changes
Dec 24, 2024
efantinatti
left a comment
There was a problem hiding this comment.
Dear Faisal Khan
Session 1:
1 - Partial. Missing type 1 and type 2 explanations.
Session 2:
2 - OK.
Session 3:
3 - Partial.
-- CROSS JOIN - Q1: Results are not correct. Consider using CROSS JOIN clause.
-- DELETE - Q1: Query is not attending the question requisite. Must delete the older record based on the time of entry.
-- UPDATE - Q1: No UPDATE clause is being used. Query is not correct and won't work per request.
Final:
4 - Check the aforementioned points prior to merging your feature branch 'assignment-two' to 'main'.
Mark: 64 points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding two models and sql codes for assignment 2
What did you learn from the changes you have made?
A lot. How to think of relationships between tables, how to extract data from tables that aren't explicitly recorded, advance sql commands, how to model table relationships in my mind in order to write the correct sql commands
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes, many. SQL commands a strong conceptual understanding of tables and how to slice and dice them to extract the information. Very challenging to grasps this way of thinking in a short period of time for a through assignment.
How were these changes tested?
Each line was tested as I worked through the assignment.
A reference to a related issue in your repository (if applicable)
None.
Checklist