Skip to content

add test code sample for graphql(sync and async) in the tutorial doc#356

Closed
hackrole wants to merge 1 commit intofastapi:masterfrom
hackrole:master
Closed

add test code sample for graphql(sync and async) in the tutorial doc#356
hackrole wants to merge 1 commit intofastapi:masterfrom
hackrole:master

Conversation

@hackrole
Copy link
Copy Markdown

@hackrole hackrole commented Jul 1, 2019

Hi, I add a code sample in the grpahql tutorial, to make the newbee wonot spend hours in writing testcases for grpahql, excepicilly async graphql testcasee.

If there any more I can do for this, just let me know, I will do my best to improve it.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2019

Codecov Report

Merging #356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #356   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         237    237           
  Lines        5552   5552           
=====================================
  Hits         5552   5552

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 195559c...1936acb. Read the comment docs.

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Aug 7, 2019

Thank you! I think this is very specific to Graphene, in fact, the test doesn't even need/use any FastAPI code.

I think this should be in Graphene docs, or maybe it's covered here: https://docs.graphene-python.org/en/latest/testing/

I would prefer not to add a lot of docs about other tools as Graphene, those docs are better covered in Graphene itself. E.g. the same way I would prefer not to cover a lot of the specifics about MySQL or MongoDB, etc. Also, those docs here could become obsolete very easily if they update them there.


But another thing I think you could do (and I encourage you to) is to write a blog post about it, and how to integrate Graphene with FastAPI, use Graphene tests, etc. Then we could link to your post from here: https://fastapi.tiangolo.com/external-links/

I'll close this now, but feel free to add more comments, issues, PRs.

@tiangolo tiangolo closed this Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants