add test code sample for graphql(sync and async) in the tutorial doc#356
add test code sample for graphql(sync and async) in the tutorial doc#356hackrole wants to merge 1 commit intofastapi:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 237 237
Lines 5552 5552
=====================================
Hits 5552 5552Continue to review full report at Codecov.
|
|
Thank you! I think this is very specific to Graphene, in fact, the test doesn't even need/use any FastAPI code. I think this should be in Graphene docs, or maybe it's covered here: https://docs.graphene-python.org/en/latest/testing/ I would prefer not to add a lot of docs about other tools as Graphene, those docs are better covered in Graphene itself. E.g. the same way I would prefer not to cover a lot of the specifics about MySQL or MongoDB, etc. Also, those docs here could become obsolete very easily if they update them there. But another thing I think you could do (and I encourage you to) is to write a blog post about it, and how to integrate Graphene with FastAPI, use Graphene tests, etc. Then we could link to your post from here: https://fastapi.tiangolo.com/external-links/ I'll close this now, but feel free to add more comments, issues, PRs. |
Hi, I add a code sample in the grpahql tutorial, to make the newbee wonot spend hours in writing testcases for grpahql, excepicilly async graphql testcasee.
If there any more I can do for this, just let me know, I will do my best to improve it.