Merged
Conversation
Member
Author
|
@clewis7 @apasarkar what about just skipping the edge method, using the bbox is actually useless for many real use cases like this where there is lots of overlap 🙃 |
Member
|
This looks amazing!! I am okay with skipping edge. When I think about doing something like clicking a contour I would be clicking near the center... |
Member
Author
|
I think I'm going to make this a function in |
Member
Author
|
@clewis7 ready for review! |
clewis7
reviewed
Jun 18, 2024
Comment on lines
+36
to
+37
| if not all(isinstance(g, Graphic) for g in graphics): | ||
| raise TypeError("all elements of `graphics` must be Graphic objects") |
Member
There was a problem hiding this comment.
Should there also be a check for if all the graphics are in the same subplot? Or would that not make a difference?
Member
Author
There was a problem hiding this comment.
We leave that to the user, so it's just a very simple function unaware of plot areas
clewis7
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes #514
WIP, need to finish edge method
get_nearest-2024-06-17_00.35.24.mp4