Prefix generated test names with user-defined test fn name#7
Merged
Y-Nak merged 2 commits intofe-lang:mainfrom May 16, 2024
Merged
Prefix generated test names with user-defined test fn name#7Y-Nak merged 2 commits intofe-lang:mainfrom
Y-Nak merged 2 commits intofe-lang:mainfrom
Conversation
Y-Nak
approved these changes
May 16, 2024
Collaborator
Y-Nak
left a comment
There was a problem hiding this comment.
LGTM!
I'll bump up the version to 0.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a minor problem with code like this:
where both of the directories contain a file called "simple.sntn", and thus two test functions called "simple" are generated. I could have manually specified a suffix to the
dir_testattribute, but I think it's better for this situation to work by default. I solved this by prefixing the generated test names with the name of the function that thedir_testattribute is attached to; in this case the generated tests aretest_func__simpleandtest_module__simple.This change is also makes the
cargo testoutput more clear when there are many test functions specified, and files with generic name. Eg