Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f92b30713
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @media (prefers-color-scheme: dark) { | ||
| :root:not([data-theme="light"]) { | ||
| --bg: #1e1e2e; | ||
| --bg-secondary: #181825; | ||
| --text: #cdd6f4; | ||
| --text-muted: #9399b2; | ||
| --accent: #89b4fa; | ||
| --accent-hover: #b4d0fb; | ||
| --text-accent: #89b4fa; | ||
| --border: #313244; | ||
| :root { | ||
| --bg: #0f0f1a; |
There was a problem hiding this comment.
Preserve
data-theme="light" override in dark-mode rules
The new dark-mode block now targets plain :root inside @media (prefers-color-scheme: dark), which means users on a dark OS will always get dark variables even when the app explicitly sets data-theme="light" from saved preference (see /src/pages/docs/index.astro theme bootstrap). Before this commit, the selector excluded data-theme="light", so the explicit light choice was respected; after this change, that override path is broken and persisted light theme no longer works on dark-system devices.
Useful? React with 👍 / 👎.
No description provided.