Release preparations 0.1.0 by feO2x · Pull Request #20 · feO2x/Light.PortableResults

feO2x · 2026-02-24T08:13:22Z

Closes #19

adds reamde
adds publish on NuGet workflow
add package release notes

Signed-off-by: Kenny Pflug <[email protected]>

Copilot

Pull request overview

This pull request prepares the Light.Results library for its initial 0.1.0 release on NuGet. The library implements the Result Pattern with serialization support for HTTP and CloudEvents, including ASP.NET Core integrations.

Changes:

Added comprehensive README.md with documentation, examples, and configuration guides
Created GitHub Actions workflow for automated NuGet package publishing on release
Added package metadata (descriptions, release notes, repository URLs, and licensing) to all project files
Added Microsoft.SourceLink.GitHub for source debugging support
Included package icon and public signing key

Reviewed changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
README.md	Comprehensive documentation with quickstart examples, usage patterns, and configuration options
.github/workflows/release-on-nuget.yml	Automated workflow for building, signing, and publishing NuGet packages
Directory.Build.props	Added version 0.1.0 for the release
src/Directory.Build.props	Added NuGet package metadata including repository URLs, licensing, icon, and SourceLink configuration
Directory.Packages.props	Added Microsoft.SourceLink.GitHub package version and reordered coverlet.collector
src/Light.Results/Light.Results.csproj	Added package description and release notes for core library
src/Light.Results.AspNetCore.Shared/Light.Results.AspNetCore.Shared.csproj	Added package description and release notes for shared ASP.NET Core functionality
src/Light.Results.AspNetCore.Mvc/Light.Results.AspNetCore.Mvc.csproj	Added package description and release notes for MVC integration
src/Light.Results.AspNetCore.MinimalApis/Light.Results.AspNetCore.MinimalApis.csproj	Added package description and release notes for Minimal APIs integration
src/Light.Results/Http/Writing/MetadataSerializationMode.cs	Removed placeholder file (type moved to SharedJsonSerialization namespace)
Light.Results.Public.snk	Added public key file for assembly signing
images/light-logo.png	Added package icon
Light.Results.slnx	Updated solution to include new workflow and README files
Various packages.lock.json files	Updated with Microsoft.SourceLink.GitHub dependencies and version reference changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-24T08:21:22Z

+      ---------------------------------
+
+      - Initial release 🚀
+      - LightActionResult and LightActionResult&lt;T> and corresponding extension methods to turn result instances into HTTP success responses or RFC 9457 (and RFC 7807) compatbile Problem Details responses.


Spelling error: "compatbile" should be "compatible".

Suggested change

- LightActionResult and LightActionResult<T> and corresponding extension methods to turn result instances into HTTP success responses or RFC 9457 (and RFC 7807) compatbile Problem Details responses.

- LightActionResult and LightActionResult<T> and corresponding extension methods to turn result instances into HTTP success responses or RFC 9457 (and RFC 7807) compatible Problem Details responses.

Copilot · 2026-02-24T08:21:23Z

+      ---------------------------------
+
+      - Initial release 🚀
+      - LightResult and LightResult&lt;T> and corresponding extension methods to turn result instances into HTTP success responses or RFC 9457 (and RFC 7807) compatbile Problem Details responses.


Spelling error: "compatbile" should be "compatible".

Suggested change

- LightResult and LightResult<T> and corresponding extension methods to turn result instances into HTTP success responses or RFC 9457 (and RFC 7807) compatbile Problem Details responses.

- LightResult and LightResult<T> and corresponding extension methods to turn result instances into HTTP success responses or RFC 9457 (and RFC 7807) compatible Problem Details responses.

Copilot · 2026-02-24T08:21:23Z

+    <EmbedUntrackedSources>true</EmbedUntrackedSources>
+    <PackageTags>streaming;memory-management;form-file</PackageTags>
+    <PackageIcon>light-logo.png</PackageIcon>
+    <PackageReadmeFile>readme.md</PackageReadmeFile>


The PackageReadmeFile references "readme.md" but the actual file is named "README.md" (uppercase). This case mismatch may cause issues on case-sensitive file systems. Update to "README.md" to match the actual filename.

Suggested change

<PackageReadmeFile>readme.md</PackageReadmeFile>

<PackageReadmeFile>README.md</PackageReadmeFile>

Copilot · 2026-02-24T08:21:23Z

+      - name: Push NuGet packages
+        env:
+          NUGET_API_KEY: ${{ secrets.NUGET_API_KEY }}
+        run: dotnet nuget push "./src/**/*.nupkg" --api-key $NUGET_API_KEY --source https://api.nuget.org/v3/index.json


Consider adding the --skip-duplicate flag to the dotnet nuget push command. Without it, the workflow will fail if a package with the same version already exists on NuGet, which could happen during re-runs or if a release is republished.

Suggested change

run: dotnet nuget push "./src/**/*.nupkg" --api-key $NUGET_API_KEY --source https://api.nuget.org/v3/index.json

run: dotnet nuget push "./src/**/*.nupkg" --api-key $NUGET_API_KEY --source https://api.nuget.org/v3/index.json --skip-duplicate

Copilot · 2026-02-24T08:21:24Z

+
+      - Initial release 🚀
+      - Result enrichment with ASP.NET Core's HttpContext
+      - Shared logic for Minimal API's and MVC's composition root


Grammar issue: "Minimal API's" should be "Minimal APIs" (plural form, not possessive). Similarly, "MVC's" should be "MVC's" or simply "MVC".

Suggested change

- Shared logic for Minimal API's and MVC's composition root

- Shared logic for Minimal APIs and MVC's composition root

Copilot · 2026-02-24T08:21:24Z

+    <IncludeSymbols>true</IncludeSymbols>
+    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
+    <EmbedUntrackedSources>true</EmbedUntrackedSources>
+    <PackageTags>streaming;memory-management;form-file</PackageTags>


The PackageTags value "streaming;memory-management;form-file" appears to be incorrect for a Result Pattern library. These tags suggest file upload/streaming functionality, which doesn't match the library's purpose. Consider using tags like "result-pattern;error-handling;functional-programming;aspnetcore;cloudevents" instead.

Suggested change

<PackageTags>streaming;memory-management;form-file</PackageTags>

<PackageTags>result-pattern;error-handling;functional-programming;aspnetcore;cloudevents</PackageTags>

feO2x · 2026-02-24T11:30:20Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-02-24T11:30:28Z

@feO2x I've opened a new pull request, #21, to work on those changes. Once the pull request is ready, I'll request review from you.

… push flag Co-authored-by: feO2x <[email protected]>

Fix review feedback: spelling, package tags, readme casing, NuGet push flag

Signed-off-by: Kenny Pflug <[email protected]>

github-actions · 2026-02-24T15:51:26Z

Package	Line Rate	Branch Rate	Complexity	Health
Light.Results	96%	94%	2300	✔
Light.Results.AspNetCore.MinimalApis	93%	80%	25	✔
Light.Results.AspNetCore.Mvc	93%	80%	26	✔
Light.Results.AspNetCore.Shared	94%	92%	28	✔
Summary	96% (3565 / 3703)	94% (1839 / 1962)	2379	✔

Minimum allowed line rate is 60%

feO2x added 11 commits February 24, 2026 05:47

chore: set up version, descriptions and package release notes

5e55419

Signed-off-by: Kenny Pflug <[email protected]>

chore: add public SNK

6a5414e

Signed-off-by: Kenny Pflug <[email protected]>

chore: add public SNK to slnx

d7c7876

Signed-off-by: Kenny Pflug <[email protected]>

ci: add release-on-nuget.yml

34bd488

Signed-off-by: Kenny Pflug <[email protected]>

chore: add release-on-nuget worfklow to slnx

9a5af3f

Signed-off-by: Kenny Pflug <[email protected]>

docs: add Key Features, Installation and Quick Start sections to readme

6a02065

Signed-off-by: Kenny Pflug <[email protected]>

chore: remove duplicate MetadataSerializationMode.cs file

b771d16

Signed-off-by: Kenny Pflug <[email protected]>

chore: add Quick Start to readme

ea97ce6

Signed-off-by: Kenny Pflug <[email protected]>

docs: add Configuration section in readme

ed8b11f

Signed-off-by: Kenny Pflug <[email protected]>

docs: fix badge version

e37e0b7

Signed-off-by: Kenny Pflug <[email protected]>

docs: finish readme

976f84f

Signed-off-by: Kenny Pflug <[email protected]>

feO2x self-assigned this Feb 24, 2026

feO2x requested a review from Copilot February 24, 2026 08:13

Copilot started reviewing on behalf of feO2x February 24, 2026 08:13 View session

feO2x added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 24, 2026

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Initial plan

e3a852b

Copilot AI mentioned this pull request Feb 24, 2026

Fix review feedback: spelling, package tags, readme casing, NuGet push flag #21

Merged

Copilot AI and others added 3 commits February 24, 2026 11:32

Apply review feedback: fix spelling, tags, readme filename, and NuGet…

f90377f

… push flag Co-authored-by: feO2x <[email protected]>

Merge pull request #21 from feO2x/copilot/sub-pr-20

bee40db

Fix review feedback: spelling, package tags, readme casing, NuGet push flag

chore: spice up Key Features section in readme

1cc862f

Signed-off-by: Kenny Pflug <[email protected]>

feO2x merged commit d002f3e into main Feb 24, 2026
2 checks passed

feO2x deleted the 19-release-preparations branch February 24, 2026 15:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release preparations 0.1.0 #20

Release preparations 0.1.0 #20
feO2x merged 15 commits intomainfrom
19-release-preparations

feO2x commented Feb 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

feO2x commented Feb 24, 2026

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	- LightActionResult and LightActionResult<T> and corresponding extension methods to turn result instances into HTTP success responses or RFC 9457 (and RFC 7807) compatbile Problem Details responses.
	- LightActionResult and LightActionResult<T> and corresponding extension methods to turn result instances into HTTP success responses or RFC 9457 (and RFC 7807) compatible Problem Details responses.

	- LightResult and LightResult<T> and corresponding extension methods to turn result instances into HTTP success responses or RFC 9457 (and RFC 7807) compatbile Problem Details responses.
	- LightResult and LightResult<T> and corresponding extension methods to turn result instances into HTTP success responses or RFC 9457 (and RFC 7807) compatible Problem Details responses.

	<PackageReadmeFile>readme.md</PackageReadmeFile>
	<PackageReadmeFile>README.md</PackageReadmeFile>

	run: dotnet nuget push "./src/*/.nupkg" --api-key $NUGET_API_KEY --source https://api.nuget.org/v3/index.json
	run: dotnet nuget push "./src/*/.nupkg" --api-key $NUGET_API_KEY --source https://api.nuget.org/v3/index.json --skip-duplicate

	- Shared logic for Minimal API's and MVC's composition root
	- Shared logic for Minimal APIs and MVC's composition root

	<PackageTags>streaming;memory-management;form-file</PackageTags>
	<PackageTags>result-pattern;error-handling;functional-programming;aspnetcore;cloudevents</PackageTags>

Conversation

feO2x commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

feO2x commented Feb 24, 2026

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feO2x commented Feb 24, 2026 •

edited

Loading