Merged
Conversation
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR renames the repository, packages, and public APIs from Light.Results to Light.PortableResults throughout the entire codebase. The rename touches 316 files and includes updates to namespaces, class names, CloudEvents wire format attributes, documentation, CI/CD pipelines, and test snapshots.
Changes:
- Repository renamed from
Light.ResultstoLight.PortableResultsincluding solution files, signing keys, and URLs - All public API types renamed from
LightResults*prefix toPortableResults*prefix - CloudEvents wire attribute key changed from
lroutcometolproutcomewith no backward compatibility - All project namespaces updated from
Light.Results.*toLight.PortableResults.* - Documentation, README, and CI/CD workflows updated to reflect new naming
Reviewed changes
Copilot reviewed 256 out of 316 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests namespace files | Updated test file namespaces from Light.Results.Tests.* to Light.PortableResults.Tests.* |
| Module.cs files | Renamed DI registration methods from AddLightResults* to AddPortableResults* |
| Options types | Renamed option classes from LightResultsHttp*Options to PortableResultsHttp*Options |
| CloudEvents constants | Changed wire attribute from lroutcome to lproutcome |
| ASP.NET Core integration | Updated MVC and Minimal APIs extension methods and attributes to PortableResults* |
| Project files | Updated all .csproj references and package descriptions |
| README.md | Updated documentation with new package names and API examples |
| CI/CD workflows | Updated GitHub Actions to use new solution and signing key names |
| Solution file | Renamed Light.Results.slnx to Light.PortableResults.slnx |
| Benchmarks | Updated benchmark code to reference renamed types and namespaces |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
Scope
This summary covers branch
22-rename-to-portable-resultscompared tomain.Change Size
1. Repository and Package Identity Renamed
The solution moved from Light.Results to Light.PortableResults across repository artifacts:
Light.Results.slnx->Light.PortableResults.slnxLight.Results.Public.snk->Light.PortableResults.Public.snkLight.PortableResults2. Project and Folder Renames Across
src/andtests/All major project directories and
.csprojnames were renamed fromLight.Results*toLight.PortableResults*,including:
This includes namespace updates and file renames for consistency.
3. Public API Naming Updates (PortableResults Prefix)
Key API names were modernized to match the new package identity.
Core option type renames
LightResultsHttpWriteOptions->PortableResultsHttpWriteOptionsLightResultsHttpReadOptions->PortableResultsHttpReadOptionsLightResultsCloudEventsWriteOptions->PortableResultsCloudEventsWriteOptionsLightResultsCloudEventsReadOptions->PortableResultsCloudEventsReadOptionsASP.NET Core integration surface
AddLightResultsForMinimalApis->AddPortableResultsForMinimalApisAddLightResultsForMvc->AddPortableResultsForMvcLightResultEndpointExtensions->PortableResultsEndpointExtensionsProducesLightResultAttribute->ProducesPortableResultAttributeLightResultsMinimalApiJsonContext->PortableResultsMinimalApiJsonContextResolveLightResultsHttpWriteOptions->ResolvePortableResultsHttpWriteOptionsModule registration/API naming updates
PortableResults*variants (including JSON converter registration and headerconversion service registration)
PortableResults*variantsPortableResults*variantsPortableResultsCloudEventsWriteOptions4. CloudEvents Contract Update:
lroutcome->lproutcomeThe reserved Light extension attribute was fully renamed:
lroutcome->lproutcomeCloudEventsConstants.LightResultsOutcomeAttributeName->CloudEventsConstants.PortableResultsOutcomeAttributeNameUpdated areas:
JsonCloudEventsExtensions)ReadOnlyMemoryCloudEventsExtensions)No backward-compatibility path for
lroutcomewas kept.5. README and Documentation Alignment
Root
README.mdwas brought in line with the renamed codebase and APIs:usingnamespaces correctedlight-portable-resultsAdditional docs updated:
AGENTS.md,src/AGENTS.md,tests/AGENTS.mdai-plansdocuments reflecting renamed CloudEvents key and product name6. CI/CD and Build Pipeline Adjustments
GitHub workflows were updated to new solution/signing names:
Light.PortableResults.slnxLight.PortableResults.slnxandLight.PortableResults.snk7. Tests and Benchmarks Updated to Match New Names
Light.PortableResults*lproutcome8. Post-Summary Cleanup (Follow-up Commit)
After this summary file was first added, a follow-up cleanup commit addressed remaining transition gaps.
CloudEvents writing API consistency
The CloudEvents writing module still exposed
AddLightResults*method names and was aligned toPortableResults*:AddLightResultsCloudEventsWriteOptions->AddPortableResultsCloudEventsWriteOptionsAddLightResultsCloudEventsAttributeConversionService->AddPortableResultsCloudEventsAttributeConversionServiceAddDefaultLightResultsCloudEventsWriteJsonConverters->AddDefaultPortableResultsCloudEventsWriteJsonConvertersThe default serializer setup call chain was updated accordingly.
Runtime/message text consistency
"No LightResultsHttpWriteOptions are configured in the DI container"to"No PortableResultsHttpWriteOptions are configured in the DI container".Package release notes consistency
Updated outdated method names in package release notes:
AddLightResultsForMinimalApis->AddPortableResultsForMinimalApisAddLightResultsForMvc->AddPortableResultsForMvcTest naming cleanup
Renamed leftover
LightResults*test method names/usages toPortableResults*in:...LightResultsErrorPayload->...PortableResultsErrorPayload)Final sweep result
A final repository-wide sweep was run for stale transition identifiers (
Light.Results,LightResults,light-results,lroutcome).Remaining references were limited to:
LightResult.csLightActionResult.csai-plans/BenchmarkDotNet.Artifacts)