Conversation
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
Signed-off-by: Kenny Pflug <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR introduces functional extensions for the Light.Results library by extracting existing functional methods from the Result<T> and Result structs into extension methods in a new Light.Results.FunctionalExtensions namespace. The implementation introduces two new interfaces (IResult<TSelf> and IResultWithValue<TSelf, TValue>) that enable generic extension methods while maintaining zero-allocation performance.
Changes:
- Added functional extension methods (Map, Bind, Tap, TapError, Match, MatchFirst, Switch, SwitchFirst, Else, FailIf, Ensure, MapError) with async variants
- Removed existing functional methods from
Result<T>andResultstructs - Introduced
IResult<TSelf>andIResultWithValue<TSelf, TValue>interfaces to enable generic extension methods - Added comprehensive test coverage for all functional extensions
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Light.Results/IResult.cs | New interface enabling generic extension methods for both result types |
| src/Light.Results/IResultWithValue.cs | New interface for results carrying success values |
| src/Light.Results/Result.cs | Removed functional methods (Map, Bind, Tap, TapError) and implemented new interfaces |
| src/Light.Results/FunctionalExtensions/*.cs | New extension methods organized by functionality (12 files) |
| tests/Light.Results.Tests/FunctionalExtensions/*.cs | Comprehensive test coverage for all extension methods |
| src/Light.Results/Light.Results.csproj | Added System.Threading.Tasks.Extensions dependency |
| Directory.Packages.props | Added System.Threading.Tasks.Extensions version 4.6.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Result<T>andResultas they are now available as extension methods