chore: Remove upper bound on dask dependency#3343
Conversation
Signed-off-by: Oliver Holworthy <[email protected]>
|
Just bumped into this conflict today when trying to add feast as a dependency in our model-training repo. Thanks for opening a PR to address this. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3343 +/- ##
==========================================
+ Coverage 67.65% 76.73% +9.07%
==========================================
Files 181 218 +37
Lines 16645 18466 +1821
==========================================
+ Hits 11262 14170 +2908
+ Misses 5383 4296 -1087
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, oliverholworthy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Motivation: Being able to use feast in an application with more recent versions of dask in a Python 3.8+ environment without having to work around conflicts due to versions specified in package.
This PR removes the upper bound on dask requirement added in #2342 This upper bound was added because newer versions of dask dropped support for Python 3.7.
However, the upper bound isn't necesesary for Python 3.7 compatibility (unless a version of dask was released that had the wrong
python_requiresspecified.)python_requiresin the pacakge config)Additional context
It seems that in practice feast has dropped support for Python 3.7: