Skip to content

feat: ignore ipynb files during apply #5177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrielaugz wants to merge 1 commit into from
+1 −0
Closed

feat: ignore ipynb files during apply #5177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/python/feast/repo_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ def get_repo_files(repo_root: Path) -> List[Path]:
p.resolve()
for p in repo_root.glob("**/*.py")
if p.is_file() and "__init__.py" != p.name
and not p.name.endswith(".ipynb") # Ignore Jupyter Notebook files during feast apply
Copy link
Copy Markdown
Contributor

@redhatHameed redhatHameed Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also if you can add .ipynb_checkpoints to ignore

Copy link
Copy Markdown
Member

@franciscojavierarceo franciscojavierarceo Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this a list of files we ignore and add .ipynb to it?

Copy link
Copy Markdown
Member

@franciscojavierarceo franciscojavierarceo Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, I see .ipynb_checkpoints in the ignore_paths but I have experienced this issue locally very frequently.

Copy link
Copy Markdown
Contributor

@redhatHameed redhatHameed Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me too, I just used to do find . -name ".ipynb_checkpoints" -type d -exec rm -rf {} +

Copy link
Copy Markdown
Member

@franciscojavierarceo franciscojavierarceo Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i do something similar

}
# Ignore all files that match any of the ignore paths in .feastignore
repo_files -= ignore_files
Expand Down