feat: Add Oracle DB as Offline store in python sdk & operator by aniketpalu · Pull Request #6017 · feast-dev/feast

aniketpalu · 2026-02-24T09:40:45Z

What this PR does / why we need it:

Oracle DB Offline Store for Feast (ibis-based)

This PR adds a native Oracle Database offline store for Feast, built on the ibis-framework's Oracle backend (ibis.oracle). It follows the same proven pattern used by the existing MSSQL ibis offline store — delegating to the shared ibis.py functions for point-in-time joins, deduplication, and feature retrieval.
The implementation is ~300 lines total (vs 1096 lines in the SQLAlchemy-based approach), with no Jinja2 templates, no dialect-specific SQL workarounds, and no manual query generation. ibis generates Oracle SQL automatically and provides native Arrow transfer via to_pyarrow().

Oracle Column Name Handling

Oracle stores unquoted identifiers in UPPERCASE. For example, CREATE TABLE t (user_id INT) stores the column as USER_ID. This store uses a passthrough approach — column names are returned exactly as Oracle stores them, with no automatic case transformation.
This means:
Unquoted columns (the standard Oracle convention): The user references them in UPPERCASE, matching what they see in Oracle tools like SQL Developer, DBeaver, or DESCRIBE table.
Quoted columns (e.g., "CamelCase"): The user references them with the exact casing used when creating the table.
This design ensures predictable behavior — what you see in Oracle is what you use in Feast. No hidden transformations, no conventions to learn.

How to Use

feature_store.yaml

project: my_project
provider: local
registry: data/registry.db

offline_store:
  type: oracle
  user: feast
  password: feast
  host: localhost
  port: 1521
  service_name: FREEPDB1

online_store:
  type: sqlite
  path: data/online_store.db

What's Tested

Tested against a live Oracle 23ai database (Oracle Free 23.26.1.0.0):

Core Feast Operations:

Oracle connectivity via ibis.oracle.connect() with schema introspection
feast apply — registering entities, feature views, and feature services
get_historical_features — point-in-time correct feature retrieval with entity DataFrame
materialize — pulling latest features from Oracle offline store into SQLite online store
get_online_features — retrieving materialized features from the online store
pull_all_from_table_or_query — direct offline store batch retrieval with date range filtering
to_pyarrow() — native Arrow transfer via ibis (no intermediate pandas conversion)

Non-Entity Retrieval (entity_df=None):

With both start_date and end_date provided
With only end_date (start calculated from feature view TTL)
With only start_date (end defaults to current time)
With neither (end defaults to current time, start calculated from TTL)

Oracle Column Name Handling:

Unquoted identifiers (UPPERCASE) — e.g., USER_ID, FEATURE_TIME, TXN_LAST_24H
Quoted mixed-case identifiers — e.g., "User_ID" and "user_iD" in the same test run
Full Feast flow (apply → historical → materialize → online) verified for both casing styles

Which issue(s) this PR fixes:

#6018

Misc

Srihari1192 · 2026-02-26T11:27:32Z

@aniketpalu Tested oracle DB configuration with feast operator and feast SDK , LGTM
Thanks

sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py

ntkathole · 2026-02-27T17:16:22Z

sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py

+
+    def _read_data_source(data_source: DataSource, repo_path: str = "") -> Table:
+        table = _read_oracle_table(con, data_source)
+        return ibis.memtable(table.execute())


reading entire table in memory? Isn't there a better way to read filtered table based on timestamps may be?

pretty sure _build_data_source_reader_for_retrieval function is completely redundant, it just repackages _build_data_source_reader for no good reason.

@ntkathole @tokoko

Added pre-filter to avoid reading the whole table. Thanks for the catch

to be clear, I don't understand why we need _build_data_source_reader_for_retrieval at all. can't you use _build_data_source_reader in get_historical_features_ibis call? that way there will be no materialization

@tokoko

Thanks for clarification, I misunderstood your earlier comment. You are right, materialization can be avoided by using _build_data_source_reader.

After this fix, needed to do a little change in building entity_row_id in ibis as r = ibis.literal("") in _generate_row_id() creates broken entity_row_id due to Oracle DB casting it as NULL.

sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py

ntkathole · 2026-02-27T17:19:35Z

Can we add documentation as well for offline store ?

ntkathole · 2026-03-06T12:04:13Z

@aniketpalu Need rebase

…-operator Signed-off-by: Aniket Paluskar <[email protected]>

Signed-off-by: Aniket Paluskar <[email protected]>

… Vulnerability Signed-off-by: Aniket Paluskar <[email protected]>

…s & validation for mutually exclusive fields Signed-off-by: Aniket Paluskar <[email protected]>

Signed-off-by: Aniket Paluskar <[email protected]>

…0 EnumTypeWrapper incompatibility Signed-off-by: Aniket Paluskar <[email protected]>

Signed-off-by: Aniket Paluskar <[email protected]>

Srihari1192

Tested the changes LGTM
Thanks @aniketpalu

…oid runtime errors Signed-off-by: Aniket Paluskar <[email protected]>

sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py

Signed-off-by: Aniket Paluskar <[email protected]>

…value in Oracle DB Signed-off-by: Aniket Paluskar <[email protected]>

… ibis date32[day] Arrow mapping Signed-off-by: Aniket Paluskar <[email protected]>

Signed-off-by: Aniket Paluskar <[email protected]>

ntkathole

looks good! Thanks @aniketpalu

…dev#6017) * feat: Add Oracle DB as Offline store in python sdk & support in feast-operator Signed-off-by: Aniket Paluskar <[email protected]> * Added oracle db dependency from ibis-framework subgroups Signed-off-by: Aniket Paluskar <[email protected]> * Operator yaml changes Signed-off-by: Aniket Paluskar <[email protected]> * Data source writer ignored parameters, fixed Signed-off-by: Aniket Paluskar <[email protected]> * Replaced raw sql with dedicated truncate_table() to fix SQL Injection Vulnerability Signed-off-by: Aniket Paluskar <[email protected]> * Minor improvements like single db connection, removal of default creds & validation for mutually exclusive fields Signed-off-by: Aniket Paluskar <[email protected]> * Fetching pre-filtered table from db Signed-off-by: Aniket Paluskar <[email protected]> * Minor formatting changes Signed-off-by: Aniket Paluskar <[email protected]> * Added Oracle DB Offline Store documentation Signed-off-by: Aniket Paluskar <[email protected]> * Resolved import error by removing OracleSource import from the __init__ Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint error by updating secret baseline Signed-off-by: Aniket Paluskar <[email protected]> * fix: Exclude qdrant from docstring tests to avoid qdrant-client 1.17.0 EnumTypeWrapper incompatibility Signed-off-by: Aniket Paluskar <[email protected]> * Generated secret.baseline to avoid lint error Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint error Signed-off-by: Aniket Paluskar <[email protected]> * Updated .secrets.baseline Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint errors Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint errors Signed-off-by: Aniket Paluskar <[email protected]> * Update sdk/python/feast/type_map.py Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: Aniket Paluskar <[email protected]> * Updated dependency lock files Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint issues in Trino Offline Store Signed-off-by: Aniket Paluskar <[email protected]> * Updated requirements Signed-off-by: Aniket Paluskar <[email protected]> * Updated pixi.lock file Signed-off-by: Aniket Paluskar <[email protected]> * Restricted non-empty feature_views in get_historical_features() to avoid runtime errors Signed-off-by: Aniket Paluskar <[email protected]> * Removed _build_data_source_reader_for_retrieval function Signed-off-by: Aniket Paluskar <[email protected]> * Modified initial query to be _ to avoid empty string casting to Null value in Oracle DB Signed-off-by: Aniket Paluskar <[email protected]> * cast DATE to TIMESTAMP in _read_oracle_table to preserve time lost by ibis date32[day] Arrow mapping Signed-off-by: Aniket Paluskar <[email protected]> * Use single database connection for pull_latest_from_table_or_query() Signed-off-by: Aniket Paluskar <[email protected]> * Improved readibility by breaking down the code into functions Signed-off-by: Aniket Paluskar <[email protected]> * Updated .secret.baseline Signed-off-by: Aniket Paluskar <[email protected]> * Updated .secret.baseline and pixi.lock Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint issue Signed-off-by: Aniket Paluskar <[email protected]> --------- Signed-off-by: Aniket Paluskar <[email protected]> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: Shizoqua <[email protected]>

aniketpalu requested a review from a team as a code owner February 24, 2026 09:40

This comment was marked as resolved.

Sign in to view

aniketpalu force-pushed the oracle-db-offline-store branch from de7b133 to 79b59da Compare February 26, 2026 18:07

tokoko reviewed Feb 27, 2026

View reviewed changes

sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py Outdated Show resolved Hide resolved

ntkathole reviewed Feb 27, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

aniketpalu force-pushed the oracle-db-offline-store branch from d8c2abb to 4fffb65 Compare March 6, 2026 07:38

ntkathole added the ok-to-test label Mar 6, 2026

aniketpalu force-pushed the oracle-db-offline-store branch from ecc47ac to 9b363eb Compare March 9, 2026 11:50

This comment was marked as resolved.

Sign in to view

aniketpalu force-pushed the oracle-db-offline-store branch from 9b363eb to ecc47ac Compare March 9, 2026 12:45

aniketpalu added 12 commits March 9, 2026 18:19

feat: Add Oracle DB as Offline store in python sdk & support in feast…

cff3a63

…-operator Signed-off-by: Aniket Paluskar <[email protected]>

Added oracle db dependency from ibis-framework subgroups

60f8d92

Signed-off-by: Aniket Paluskar <[email protected]>

Operator yaml changes

9f00168

Signed-off-by: Aniket Paluskar <[email protected]>

Data source writer ignored parameters, fixed

07e6969

Signed-off-by: Aniket Paluskar <[email protected]>

Replaced raw sql with dedicated truncate_table() to fix SQL Injection…

1fb6720

… Vulnerability Signed-off-by: Aniket Paluskar <[email protected]>

Minor improvements like single db connection, removal of default cred…

3abef8c

…s & validation for mutually exclusive fields Signed-off-by: Aniket Paluskar <[email protected]>

Fetching pre-filtered table from db

b991288

Signed-off-by: Aniket Paluskar <[email protected]>

Minor formatting changes

af7e7ee

Signed-off-by: Aniket Paluskar <[email protected]>

Added Oracle DB Offline Store documentation

41e0901

Signed-off-by: Aniket Paluskar <[email protected]>

Resolved import error by removing OracleSource import from the __init__

d4387a8

Signed-off-by: Aniket Paluskar <[email protected]>

Fixed lint error by updating secret baseline

b0e96d0

Signed-off-by: Aniket Paluskar <[email protected]>

fix: Exclude qdrant from docstring tests to avoid qdrant-client 1.17.…

07c5e9a

…0 EnumTypeWrapper incompatibility Signed-off-by: Aniket Paluskar <[email protected]>

aniketpalu and others added 2 commits March 9, 2026 18:44

Merge branch 'master' into oracle-db-offline-store

04adc97

Updated requirements

e91fa8d

Signed-off-by: Aniket Paluskar <[email protected]>

This comment was marked as resolved.

Sign in to view

aniketpalu and others added 2 commits March 9, 2026 19:38

Updated pixi.lock file

caed7c8

Signed-off-by: Aniket Paluskar <[email protected]>

Merge branch 'master' into oracle-db-offline-store

de9759e

Srihari1192 approved these changes Mar 9, 2026

View reviewed changes

aniketpalu and others added 5 commits March 9, 2026 20:32

Merge branch 'master' into oracle-db-offline-store

e40a355

Merge branch 'master' into oracle-db-offline-store

c71cdfd

Merge branch 'master' into oracle-db-offline-store

9a20c65

Merge branch 'master' into oracle-db-offline-store

9880a56

Restricted non-empty feature_views in get_historical_features() to av…

5335b0d

…oid runtime errors Signed-off-by: Aniket Paluskar <[email protected]>

aniketpalu requested a review from ntkathole March 10, 2026 09:03

ntkathole reviewed Mar 10, 2026

View reviewed changes

sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py Outdated Show resolved Hide resolved

aniketpalu and others added 9 commits March 10, 2026 16:11

Removed _build_data_source_reader_for_retrieval function

c706b0b

Signed-off-by: Aniket Paluskar <[email protected]>

Modified initial query to be _ to avoid empty string casting to Null …

414c0e0

…value in Oracle DB Signed-off-by: Aniket Paluskar <[email protected]>

cast DATE to TIMESTAMP in _read_oracle_table to preserve time lost by…

5b84e73

… ibis date32[day] Arrow mapping Signed-off-by: Aniket Paluskar <[email protected]>

Use single database connection for pull_latest_from_table_or_query()

92f78ca

Signed-off-by: Aniket Paluskar <[email protected]>

Improved readibility by breaking down the code into functions

c79ba55

Signed-off-by: Aniket Paluskar <[email protected]>

Merge branch 'master' into oracle-db-offline-store

95f7f55

Merge branch 'master' into oracle-db-offline-store

1181be1

Updated .secret.baseline

b54c2a2

Signed-off-by: Aniket Paluskar <[email protected]>

Updated .secret.baseline and pixi.lock

fe797ed

Signed-off-by: Aniket Paluskar <[email protected]>

aniketpalu requested a review from tokoko March 10, 2026 18:19

Fixed lint issue

466e2d2

Signed-off-by: Aniket Paluskar <[email protected]>

aniketpalu requested a review from ntkathole March 11, 2026 05:39

aniketpalu force-pushed the oracle-db-offline-store branch from ff2104a to 466e2d2 Compare March 11, 2026 07:14

Conflicts resolved

7670a90

Signed-off-by: Aniket Paluskar <[email protected]>

ntkathole approved these changes Mar 14, 2026

View reviewed changes

ntkathole merged commit 9d35368 into feast-dev:master Mar 14, 2026
29 checks passed

Conversation

aniketpalu commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Oracle DB Offline Store for Feast (ibis-based)

Oracle Column Name Handling

How to Use

What's Tested

Core Feast Operations:

Non-Entity Retrieval (entity_df=None):

Oracle Column Name Handling:

Which issue(s) this PR fixes:

Misc

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Srihari1192 commented Feb 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ntkathole Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

tokoko Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

aniketpalu Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

tokoko Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aniketpalu Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ntkathole commented Feb 27, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

ntkathole commented Mar 6, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Srihari1192 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ntkathole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aniketpalu commented Feb 24, 2026 •

edited

Loading

tokoko Mar 6, 2026 •

edited

Loading

aniketpalu Mar 10, 2026 •

edited

Loading