feat: Add Claude Code agent skills for Feast#6081
Merged
ntkathole merged 6 commits intofeast-dev:masterfrom Mar 16, 2026
Merged
feat: Add Claude Code agent skills for Feast#6081ntkathole merged 6 commits intofeast-dev:masterfrom
ntkathole merged 6 commits intofeast-dev:masterfrom
Conversation
Closed
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
|
@Sagargupta16 The other PR merged, would you like to make any update to this or good to merge? |
Contributor
Author
|
Thanks @ntkathole! No updates needed -- this is good to merge as-is. All CI checks are passing and the Devin review feedback has been addressed. Appreciate the review! |
Add two agent skills following the anthropics/skills SKILL.md format: - feast-dev: Development guide for contributors covering setup, testing, linting, code style, project structure, and key abstractions - feast-feature-engineering: User-facing guide for building feature stores covering feature definitions, materialization, online/offline retrieval, on-demand transformations, and CLI reference Closes feast-dev#5976 Signed-off-by: Sagar Gupta <[email protected]>
…bility - Move from .claude/skills/ to skills/ for platform-agnostic placement - Add license, compatibility, and metadata fields per agentskills.io spec - Skills now work with Claude Code, OpenAI Codex, and any Agent Skills compatible tool Addresses feedback from @franciscojavierarceo regarding OpenAI compatibility. Signed-off-by: Sagar Gupta <[email protected]>
Remove feast-feature-engineering skill to avoid overlap with feast-dev#6007 which covers user-facing content more comprehensively. This PR now focuses exclusively on the developer/contributor workflow skill. Signed-off-by: Sagar Gupta <[email protected]>
Address Devin Review findings: - Use make install-python-dependencies-dev instead of uv pip install - Remove nonexistent start-local-integration-tests target - Fix type-check command to cd sdk/python && python -m mypy feast - Add make test-python-unit-fast and make precommit-check targets Signed-off-by: Sagar Gupta <[email protected]>
Address Devin Review finding: the example pytest commands referenced test_feature_store.py which doesn't exist. The actual file is test_unit_feature_store.py. Also use -k flag for test name filtering instead of :: class notation. Signed-off-by: Sagar Gupta <[email protected]>
Signed-off-by: Sagar Gupta <[email protected]>
25decb4 to
fbbb452
Compare
ntkathole
approved these changes
Mar 16, 2026
Anarion-zuo
pushed a commit
to Anarion-zuo/feast
that referenced
this pull request
Mar 17, 2026
* feat: add Claude Code agent skills for Feast Add two agent skills following the anthropics/skills SKILL.md format: - feast-dev: Development guide for contributors covering setup, testing, linting, code style, project structure, and key abstractions - feast-feature-engineering: User-facing guide for building feature stores covering feature definitions, materialization, online/offline retrieval, on-demand transformations, and CLI reference Closes feast-dev#5976 Signed-off-by: Sagar Gupta <[email protected]> * refactor: move skills to top-level dir, add Agent Skills spec compatibility - Move from .claude/skills/ to skills/ for platform-agnostic placement - Add license, compatibility, and metadata fields per agentskills.io spec - Skills now work with Claude Code, OpenAI Codex, and any Agent Skills compatible tool Addresses feedback from @franciscojavierarceo regarding OpenAI compatibility. Signed-off-by: Sagar Gupta <[email protected]> * refactor: scope to dev/contributor skill only Remove feast-feature-engineering skill to avoid overlap with feast-dev#6007 which covers user-facing content more comprehensively. This PR now focuses exclusively on the developer/contributor workflow skill. Signed-off-by: Sagar Gupta <[email protected]> * fix: align commands with Makefile and CLAUDE.md Address Devin Review findings: - Use make install-python-dependencies-dev instead of uv pip install - Remove nonexistent start-local-integration-tests target - Fix type-check command to cd sdk/python && python -m mypy feast - Add make test-python-unit-fast and make precommit-check targets Signed-off-by: Sagar Gupta <[email protected]> * fix: correct test file path to test_unit_feature_store.py Address Devin Review finding: the example pytest commands referenced test_feature_store.py which doesn't exist. The actual file is test_unit_feature_store.py. Also use -k flag for test name filtering instead of :: class notation. Signed-off-by: Sagar Gupta <[email protected]> * fix: correct CLI entry point path to cli/cli.py Signed-off-by: Sagar Gupta <[email protected]> --------- Signed-off-by: Sagar Gupta <[email protected]> Signed-off-by: aaronzuo <[email protected]>
Shizoqua
pushed a commit
to Shizoqua/feast
that referenced
this pull request
Mar 18, 2026
* feat: add Claude Code agent skills for Feast Add two agent skills following the anthropics/skills SKILL.md format: - feast-dev: Development guide for contributors covering setup, testing, linting, code style, project structure, and key abstractions - feast-feature-engineering: User-facing guide for building feature stores covering feature definitions, materialization, online/offline retrieval, on-demand transformations, and CLI reference Closes feast-dev#5976 Signed-off-by: Sagar Gupta <[email protected]> * refactor: move skills to top-level dir, add Agent Skills spec compatibility - Move from .claude/skills/ to skills/ for platform-agnostic placement - Add license, compatibility, and metadata fields per agentskills.io spec - Skills now work with Claude Code, OpenAI Codex, and any Agent Skills compatible tool Addresses feedback from @franciscojavierarceo regarding OpenAI compatibility. Signed-off-by: Sagar Gupta <[email protected]> * refactor: scope to dev/contributor skill only Remove feast-feature-engineering skill to avoid overlap with feast-dev#6007 which covers user-facing content more comprehensively. This PR now focuses exclusively on the developer/contributor workflow skill. Signed-off-by: Sagar Gupta <[email protected]> * fix: align commands with Makefile and CLAUDE.md Address Devin Review findings: - Use make install-python-dependencies-dev instead of uv pip install - Remove nonexistent start-local-integration-tests target - Fix type-check command to cd sdk/python && python -m mypy feast - Add make test-python-unit-fast and make precommit-check targets Signed-off-by: Sagar Gupta <[email protected]> * fix: correct test file path to test_unit_feature_store.py Address Devin Review finding: the example pytest commands referenced test_feature_store.py which doesn't exist. The actual file is test_unit_feature_store.py. Also use -k flag for test name filtering instead of :: class notation. Signed-off-by: Sagar Gupta <[email protected]> * fix: correct CLI entry point path to cli/cli.py Signed-off-by: Sagar Gupta <[email protected]> --------- Signed-off-by: Sagar Gupta <[email protected]> Signed-off-by: Shizoqua <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Adds Claude Code agent skills to the Feast repository, as requested in #5976.
Two skills are included:
1.
feast-dev-- Development/contributor skill covering:2.
feast-feature-engineering-- User-facing skill covering:Both skills use the
SKILL.mdformat from anthropics/skills and are placed under.claude/skills/following the Claude Code convention.Which issue(s) this PR fixes
Closes #5976
Does this PR introduce a user-facing change
NONE (developer tooling only)
Release note