feat: Add online store read and ODFV transformation duration metrics with per-ODFV opt-in#6125
Open
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
Open
feat: Add online store read and ODFV transformation duration metrics with per-ODFV opt-in#6125ntkathole wants to merge 1 commit intofeast-dev:masterfrom
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jyejare
approved these changes
Mar 18, 2026
Collaborator
jyejare
left a comment
There was a problem hiding this comment.
LGTM, few minor comments.
Signed-off-by: ntkathole <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds three new Prometheus histogram metrics to the Feast feature server - online store reads, read-path ODFV transformations, and write-path ODFV transformations.
feast_feature_server_online_store_read_duration_seconds- captures the total time spent reading from the online store (covers both sync for-loop and async asyncio.gather paths across all backends)feast_feature_server_transformation_duration_seconds(odfv_name, mode) - captures per-ODFV read-path transformation time during /get-online-features (Pandas, Python, Substrait modes)feast_feature_server_write_transformation_duration_seconds(odfv_name, mode) - captures per-ODFV write-path transformation time during push/materialize with write_to_online_store=True