fix: Fix missing error handling for resource_counts endpoint#6131
Open
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
Open
fix: Fix missing error handling for resource_counts endpoint#6131ntkathole wants to merge 1 commit intofeast-dev:masterfrom
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
Conversation
Signed-off-by: ntkathole <[email protected]>
Srihari1192
approved these changes
Mar 19, 2026
Contributor
Srihari1192
left a comment
There was a problem hiding this comment.
Tested by applying all permissions combinations , LGTM
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
/metrics/resource_countsendpoint fails entirely when a user's permissions restrict access to any resource type.The root cause is that the ListEntities and ListDataSources gRPC calls in count_resources_for_project() were not wrapped in try/except, unlike the other four resource types which already handled errors gracefully.
Fix: Wrap the entities and data_sources gRPC calls in try/except blocks (matching the existing pattern for saved_datasets, features, feature_views, and feature_services). When a FeastPermissionError is raised for a restricted resource type, it now returns 0 for that type instead of failing the entire endpoint.