Skip to content

feat: Provision minimal TokenReview RBAC for OIDC auth and add SSL error logging in token parser #6240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniketpalu wants to merge 2 commits into
base: master
Choose a base branch
from
+73 −3
Open

feat: Provision minimal TokenReview RBAC for OIDC auth and add SSL error logging in token parser #6240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f6f3cd
feat: Provision minimal TokenReview RBAC for OIDC auth and add SSL er…
aniketpalu Apr 8, 2026
8c8b79d
Avoid deleting shared OIDC ClusterRole during auth type transitions
aniketpalu Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra/feast-operator/bundle/manifests/feast-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ metadata:
}
]
capabilities: Basic Install
createdAt: "2026-04-08T14:26:31Z"
createdAt: "2026-04-08T12:09:54Z"
operators.operatorframework.io/builder: operator-sdk-v1.38.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v4
name: feast-operator.v0.62.0
Expand Down
74 changes: 72 additions & 2 deletions infra/feast-operator/internal/controller/authz/authz.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
// Deploy the feast authorization
func (authz *FeastAuthorization) Deploy() error {
if authz.isKubernetesAuth() {
authz.cleanupOidcRbac()
return authz.deployKubernetesAuth()
}

Expand All @@ -27,12 +28,14 @@ func (authz *FeastAuthorization) Deploy() error {
apimeta.RemoveStatusCondition(&authz.Handler.FeatureStore.Status.Conditions, feastKubernetesAuthConditions[metav1.ConditionTrue].Type)

if authz.isOidcAuth() {
if err := authz.createFeastClusterRole(); err != nil {
if err := authz.createOidcClusterRole(); err != nil {
return err
}
if err := authz.createFeastClusterRoleBinding(); err != nil {
if err := authz.createOidcClusterRoleBinding(); err != nil {
return err
}
} else {
authz.cleanupOidcRbac()
}

return nil
Expand Down Expand Up @@ -327,6 +330,73 @@ func (authz *FeastAuthorization) setAuthRole(role *rbacv1.Role) error {
return controllerutil.SetControllerReference(authz.Handler.FeatureStore, role, authz.Handler.Scheme)
}

func (authz *FeastAuthorization) createOidcClusterRole() error {
logger := log.FromContext(authz.Handler.Context)
clusterRole := &rbacv1.ClusterRole{
ObjectMeta: metav1.ObjectMeta{Name: authz.getOidcClusterRoleName()},
}
clusterRole.SetGroupVersionKind(rbacv1.SchemeGroupVersion.WithKind("ClusterRole"))
if op, err := controllerutil.CreateOrUpdate(authz.Handler.Context, authz.Handler.Client, clusterRole, controllerutil.MutateFn(func() error {
clusterRole.Labels = authz.getLabels()
clusterRole.Rules = []rbacv1.PolicyRule{
{
APIGroups: []string{"authentication.k8s.io"},
Resources: []string{"tokenreviews"},
Verbs: []string{"create"},
},
}
return nil
})); err != nil {
return err
} else if op == controllerutil.OperationResultCreated || op == controllerutil.OperationResultUpdated {
logger.Info("Successfully reconciled", "ClusterRole", clusterRole.Name, "operation", op)
}
return nil
}

func (authz *FeastAuthorization) createOidcClusterRoleBinding() error {
logger := log.FromContext(authz.Handler.Context)
crb := &rbacv1.ClusterRoleBinding{
ObjectMeta: metav1.ObjectMeta{Name: authz.getOidcClusterRoleBindingName()},
}
crb.SetGroupVersionKind(rbacv1.SchemeGroupVersion.WithKind("ClusterRoleBinding"))
if op, err := controllerutil.CreateOrUpdate(authz.Handler.Context, authz.Handler.Client, crb, controllerutil.MutateFn(func() error {
crb.Labels = authz.getLabels()
crb.Subjects = []rbacv1.Subject{
{
Kind: "ServiceAccount",
Name: authz.getFeastServiceAccountName(),
Namespace: authz.Handler.FeatureStore.Namespace,
},
}
crb.RoleRef = rbacv1.RoleRef{
APIGroup: rbacv1.GroupName,
Kind: "ClusterRole",
Name: authz.getOidcClusterRoleName(),
}
return nil
})); err != nil {
return err
} else if op == controllerutil.OperationResultCreated || op == controllerutil.OperationResultUpdated {
logger.Info("Successfully reconciled", "ClusterRoleBinding", crb.Name, "operation", op)
}
return nil
}

func (authz *FeastAuthorization) cleanupOidcRbac() {
crb := &rbacv1.ClusterRoleBinding{ObjectMeta: metav1.ObjectMeta{Name: authz.getOidcClusterRoleBindingName()}}
crb.SetGroupVersionKind(rbacv1.SchemeGroupVersion.WithKind("ClusterRoleBinding"))
_ = authz.Handler.Client.Delete(authz.Handler.Context, crb)
}

func (authz *FeastAuthorization) getOidcClusterRoleName() string {
return "feast-oidc-token-review"
}

func (authz *FeastAuthorization) getOidcClusterRoleBindingName() string {
return services.GetFeastName(authz.Handler.FeatureStore) + "-oidc-token-review"
}

func (authz *FeastAuthorization) getLabels() map[string]string {
return map[string]string{
services.NameLabelKey: authz.Handler.FeatureStore.Name,
Expand Down
Loading