Open
Conversation
Gamemode hardcoded to survival for testing
Greatly simplify code Add an ad hoc gamemode changing system
Member
|
Is this something you want me to look at soon? |
Contributor
Author
|
This PR actually feels mostly finished. I added a feature that allows the player to change their gamemode by writing 's' or 'c' in the chat, and I am not sure whether we want to keep push that to main. It does howerver seem like a good placeholder before we get actual commands. Other than that, I am happy with the rest and it is up for review. |
Defman
approved these changes
Aug 29, 2022
Member
Defman
left a comment
There was a problem hiding this comment.
Looks good, its a bit wide as its also implementing a simple effect api. Hopefully a future API could take this simple api and improve upon it.
The code is quite self explanatory, but could be nice with a few references to the constants and etc.
I noticed the CI is complaining about noun vs no_run.
Remove effects system
Contributor
Author
|
Anything else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing breaking blocks in survival
Status
Description
The goal of this PR is to implement the survival mining mechanic. This depends on potion effects (haste and mining fatigue) and physics (player in water/flying). The blocks currently do not drop items on the ground, nor does mining decrease durability.
I believe that the related issues can be resolved at a later time, simply because mining is an integral part of the game and works well enough without these features.
Related issues
Original issue #351
Potion effects #430
Physics #357
Checklist
cargo fmt,cargo clippy --all-targets,cargo build --releaseandcargo testand fixed any generated errors!