Added data field to the Particle Struct and particles system#529
Open
leElvyn wants to merge 3 commits intofeather-rs:mainfrom
Open
Added data field to the Particle Struct and particles system#529leElvyn wants to merge 3 commits intofeather-rs:mainfrom
leElvyn wants to merge 3 commits intofeather-rs:mainfrom
Conversation
Contributor
|
What is particle data? Is it particle speed or what? If so, I think it should be renamed (and also changed on wiki.vg) |
Member
|
it usually means speed, but for some particles it changes other stuff like colour fade speed, size variations etc. particle data is fine in my opinion. not sure why i didnt include it originally when i did the particle stuff |
Contributor
|
Color transitions, colors, block data and other particle stuff is defined in ParticleKind (https://wiki.vg/Protocol#Particle) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added data field to the Particle Struct and particles system
Status
Description
data: f32to struct struct Particle.send_particle()Related issues
Leave empty if none
Checklist
cargo fmt,cargo clippy --all-targets,cargo build --releaseandcargo testand fixed any generated errors!Note: if you locally don't get any errors, but GitHub Actions fails (especially at
clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.