Merged
Conversation
Deploying feathers-utils with
|
| Latest commit: |
6ee151e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09a248d6.feathers-utils.pages.dev |
| Branch Preview URL: | https://feat-zip-data-result.feathers-utils.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new utility function,
zipDataResult, to the codebase, along with comprehensive type and behavior tests, documentation, and index exports. The main goal is to provide a standardized way to pair updataandresultitems in Feathers hooks, supporting both single objects and arrays, and handling edge cases such as mismatched array lengths.The most important changes are:
New Utility Functionality:
zipDataResultutility inzip-data-result.util.ts, which pairscontext.dataandcontext.resultitems by index forafterandaroundhooks oncreate,update, andpatchmethods. The function supports both array and single-object inputs, and includes anonMismatchoption for handling array length mismatches.Testing:
zip-data-result.util.test.tsto verify types, correct pairing logic, edge cases (such as empty arrays and mismatched lengths), and the behavior of theonMismatchoption.Documentation:
zip-data-result.util.md, to describe the purpose and usage ofzipDataResult.Exports and Integration:
zipDataResultfrom the main utilities index (src/utils/index.ts) so it is available for use throughout the codebase.zipDataResultin the test utility list intest/index.test.tsto ensure it is covered by global utility tests.