Merged
Conversation
Deploying feathers-utils with
|
| Latest commit: |
cf1357c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5bd142af.feathers-utils.pages.dev |
| Branch Preview URL: | https://feat-chunk-find.feathers-utils.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new utility function,
chunkFind, for efficiently iterating over paginated results from Feathers services, and enhances test coverage for bothchunkFindanditerateFind. It also improves the flexibility and scalability of theiterateFindtests. The most important changes are grouped below:New Utility Function
chunkFindfunction inchunk-find.util.ts, enabling async iteration over paginated service results for batch processing of large datasets. This includes robust parameter handling and always paginates results, even ifpaginate: falseis set.chunkFindfromsrc/utils/index.tsto make it available throughout the codebase.chunkFindinchunk-find.util.md.Test Coverage and Improvements
chunkFindinchunk-find.util.test.ts, covering basic usage, skipping items, custom chunk sizes, querying, and pagination behavior.iterateFindtests initerate-find.util.test.tsby increasing the dataset size, improving chunk size flexibility, and adding tests for pagination overrides and large limits. [1] [2] [3] [4] [5]Utility Function Improvements
iterateFindiniterate-find.util.tsto support custom$limitvalues and improved pagination parameter handling.Test Suite Integration
chunkFindin the main test suite index for utility function coverage.