Added WebSocket Examples for REQ-REP and PUB-SUB#102
Open
jassems wants to merge 7 commits intofeatherweight:masterfrom
Open
Added WebSocket Examples for REQ-REP and PUB-SUB#102jassems wants to merge 7 commits intofeatherweight:masterfrom
jassems wants to merge 7 commits intofeatherweight:masterfrom
Conversation
Author
|
v1 FTW WebSocket API ready and integrated into examples. |
…h any "custom arguments" to pass along to the callback (convenience) and the scope in which to call the callback (defaults to scope of the FtwWebSocketRequster instance) - the callback function is passed the reply (object) as the first argument, and any "custom arguments" as the second argument - onMessage also / still fires for all received messages if specified, else is silent - ToDo: add these same "custom" capabilities to the standard callbacks as well (ex. onMessage)
…ching all with onMessage - minor updates / comments to the other existing examples
Member
|
I'll soon be looking at this, but at first glance have the following feedback: perhaps we can use native DOM events rather than jQuery as a dependency? This would require running on a modern, compliant browser, but that shouldn't be a problem anymore. The spirit here is to make examples as bare-bones as possible -- ESPECIALLY because I'm interested in also converting this into a Test. (e.g., launch the page in a default browser, then inspect output expected from LV side.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples - have a look.
Related - when I formalize the javascript nanomsg websocket API, I'll reach out to pull that under the src directory?
Perhaps:
Thoughts: