Skip to content

assignment 2 submission#2

Open
feeza2025 wants to merge 3 commits intomainfrom
assignment-2
Open

assignment 2 submission#2
feeza2025 wants to merge 3 commits intomainfrom
assignment-2

Conversation

@feeza2025
Copy link
Copy Markdown
Owner

@feeza2025 feeza2025 commented Dec 8, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Made changes to assignment 2 notebook. I added codes to the subroutines.

What did you learn from the changes you have made?

I learnt how to read lines from a file using python and how to use numpy to calculate mean, min and max

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

For this assignment I was following the lines that says 'YOUR CODE HERE:...' which was very convenient. So, I was mostly focused on writing code that was requested.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

It was my first time learning about readlines(). I wasn't sure how to loop through readlines(), but after reviewing the slides and doing a bit of searching I realized that for loop and readlines() in python work well together.

How were these changes tested?

I ran the test cases, and I also added extra test cases. For the mean, min and max, I uploaded the first csv file ( inflammation_01.csv) to Google spreadsheet and calculated the mean, max and min. Then I compared the values. For the detect_problems() subroutine, I created an extra test case. On my local system, I changed the first row of inflammation_06.csv to all zeros so the mean for the first patient would be zero, and detect_problems() would return True.

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

@feeza2025
Copy link
Copy Markdown
Owner Author

feeza2025 commented Dec 8, 2025

I updated detect_problems(file_path) after this pull request. I saw a simple way how to remove couple lines of code.

Copy link
Copy Markdown

@efantinatti efantinatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ Q1 is OK. Q2 is excellent! Could try testing a different parameter other then the three (min, max and mean). Q3 OK. Could also scan all the files and look for more True values.

Best,
E. Fantinatti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants