Open
Conversation
Owner
Author
|
I updated |
efantinatti
approved these changes
Dec 11, 2025
efantinatti
left a comment
There was a problem hiding this comment.
Hi @ Q1 is OK. Q2 is excellent! Could try testing a different parameter other then the three (min, max and mean). Q3 OK. Could also scan all the files and look for more True values.
Best,
E. Fantinatti
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Made changes to assignment 2 notebook. I added codes to the subroutines.
What did you learn from the changes you have made?
I learnt how to read lines from a file using python and how to use numpy to calculate mean, min and max
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
For this assignment I was following the lines that says 'YOUR CODE HERE:...' which was very convenient. So, I was mostly focused on writing code that was requested.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
It was my first time learning about readlines(). I wasn't sure how to loop through readlines(), but after reviewing the slides and doing a bit of searching I realized that for loop and readlines() in python work well together.
How were these changes tested?
I ran the test cases, and I also added extra test cases. For the mean, min and max, I uploaded the first csv file ( inflammation_01.csv) to Google spreadsheet and calculated the mean, max and min. Then I compared the values. For the detect_problems() subroutine, I created an extra test case. On my local system, I changed the first row of inflammation_06.csv to all zeros so the mean for the first patient would be zero, and detect_problems() would return True.
A reference to a related issue in your repository (if applicable)
Checklist