Merged
Conversation
…nd the mockPCVDeposit
fa0f2dd to
394d98e
Compare
Joeysantoro
previously requested changes
Oct 19, 2021
Joeysantoro
reviewed
Nov 5, 2021
Joeysantoro
reviewed
Nov 5, 2021
Contributor
Author
|
todo: add tests for pcvDepositSingle |
Joeysantoro
reviewed
Nov 7, 2021
Joeysantoro
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCV Deposit Aggregator.
Each PCV Deposit Aggregator sits below its parent RewardsAssetManager, and is in charge of allocating to and from individual PCV Deposits for its particular currency. This could be ETH or tokens.
The interface (IPCVDepositAggregator) can be found here
Each PCV Deposit controlled by each aggregator will have a relative "weight", similar to how TribalChief works. When funds are needed to be withdrawn from this particular-currency asset, the RewardsAggregator that sits atop each aggregator will call into the aggregator with withdraw(). For the inverse, deposit()
The PCV Deposit Aggregator will need to intelligently withdraw, deposit, and occasionally rebalance funds so that the target weights remain generally correct (though this cannot be a strict requirement due to fluctuations in underlying value and yield)
Todo: