don't crash if no page extensions are registered, issue a warning instead.#386
Closed
andrinheusser wants to merge 1 commit intofeincms:masterfrom
andrinheusser:page_extensions_fix
Closed
don't crash if no page extensions are registered, issue a warning instead.#386andrinheusser wants to merge 1 commit intofeincms:masterfrom andrinheusser:page_extensions_fix
andrinheusser wants to merge 1 commit intofeincms:masterfrom
andrinheusser:page_extensions_fix
Conversation
Member
There was a problem hiding this comment.
That's too much code inside a try..except clause. Smaller bugfix arriving in xx minutes...
matthiask
added a commit
that referenced
this pull request
Feb 15, 2013
* master: Fix #386: Do not crash in feincms_nav if no extensions registered Update docs/contenttypes.rst Conflicts: feincms/module/page/templatetags/feincms_page_tags.py
balmaster
added a commit
to balmaster/feincms
that referenced
this pull request
Mar 10, 2014
# By Matthias Kestenholz (9) and others # Via Matthias Kestenholz * v1.6.4: (26 commits) FeinCMS v1.6.4 Fix feincms#390: No longer depend on return value of add-row handler. Fix feincms#386: Do not crash in feincms_nav if no extensions registered Revert commit 3ceb1a3. The attempt at elegance caused a bug where reverse relations didn't always end up cached. Update docs/contenttypes.rst Better be safe: Escape item titles in the tree editor Make datepublisher save aware datetimes Add a test related to 3ceb1a3 VideoContent: Use protocol-relative URLs when embedding Last patch re feincms#323 was a sledgehammer to crack a walnut. This is a better solution. Fix feincms#373: Video embedding on SSL-secured websites Adding a 'force' parameter to ensure_completely_loaded, and a forced call when a content_type is added. See feincms#323 Blog entries do not have a redirect_to attribute Fix feincms#376: Intermittent crashes in RSSContent.cache_content fix AttributeError when using cleanse with section content Added patch to frontend bug cookies check Reset personal data Avoid error for unbound local variable in tag Fix feincms#366: Wrong number of parameters for get_inline_instances in Django 1.5 fix typos: i.e. stands for d.h. e.g. for z.B. ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feincms_nav won't crash anymore if no Page.register_extensions() call is present.