[SQL] Add the value of the property 'skip_unused_columns' for the table to the generated Rust code#5958
Conversation
mythical-fred
approved these changes
Mar 31, 2026
| package org.dbsp.sqlCompiler.compiler.backend.rust; | ||
|
|
||
| import com.fasterxml.jackson.databind.JsonNode; | ||
| import com.fasterxml.jackson.databind.jsonFormatVisitors.JsonObjectFormatVisitor; |
There was a problem hiding this comment.
Nit: JsonObjectFormatVisitor is imported but never used — remove this line.
Contributor
Author
|
This is the only changed output: |
…le to the generated Rust code Signed-off-by: Mihai Budiu <[email protected]>
We have test coverage for connector-level skip_unused_columns. This commit adds a test that checks that this attribute can also be picked up from a table-level property. It uses the TPCH test, adding the attribute to one of the columns and checking that the column ends up with NULL values in that column. Signed-off-by: Leonid Ryzhyk <[email protected]>
Contributor
|
I added a test |
ryzhyk
approved these changes
Apr 2, 2026
Signed-off-by: feldera-bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was part of 'properties', which were skipped in the generated Rust code.
Fixes #5957