Skip to content

Revert "ci: skip build phases on re-enqueue if artifacts already exist"#5978

Merged
jyotshnayaparla-00 merged 2 commits intomainfrom
revert-60b70a96
Apr 3, 2026
Merged

Revert "ci: skip build phases on re-enqueue if artifacts already exist"#5978
jyotshnayaparla-00 merged 2 commits intomainfrom
revert-60b70a96

Conversation

@jyotshnayaparla-00
Copy link
Copy Markdown
Contributor

This reverts commit 60b70a9.

Fixes #5893

@jyotshnayaparla-00 jyotshnayaparla-00 self-assigned this Apr 1, 2026
@jyotshnayaparla-00 jyotshnayaparla-00 requested a review from gz April 1, 2026 22:16
Copy link
Copy Markdown

@mythical-fred mythical-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — all five files from the original commit are reverted correctly this time.

@gz gz added this pull request to the merge queue Apr 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 2, 2026
@jyotshnayaparla-00 jyotshnayaparla-00 added this pull request to the merge queue Apr 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 2, 2026
@gz
Copy link
Copy Markdown
Contributor

gz commented Apr 2, 2026

@jyotshnayaparla-00 if you find the run in the actions tab it shows the following problem

https://github.com/feldera/feldera/actions/runs/23907546377

(Line: 75, Col: 13): Job 'invoke-tests-web-console-e2e' depends on unknown job 'check-prior-build'., (Line: 215, Col: 13): Job 'cancel-if-tests-web-console-integration-failed' depends on job 'invoke-tests-web-console-e2e' which creates a cycle in the dependency graph., (Line: 299, Col: 9): Job 'main' depends on job 'invoke-tests-web-console-e2e' which creates a cycle in the dependency graph.

@jyotshnayaparla-00
Copy link
Copy Markdown
Contributor Author

@jyotshnayaparla-00 if you find the run in the actions tab it shows the following problem

https://github.com/feldera/feldera/actions/runs/23907546377

(Line: 75, Col: 13): Job 'invoke-tests-web-console-e2e' depends on unknown job 'check-prior-build'., (Line: 215, Col: 13): Job 'cancel-if-tests-web-console-integration-failed' depends on job 'invoke-tests-web-console-e2e' which creates a cycle in the dependency graph., (Line: 299, Col: 9): Job 'main' depends on job 'invoke-tests-web-console-e2e' which creates a cycle in the dependency graph.

Thanks for catching that! The revert missed removing check-prior-build from invoke-tests-web-console-e2e's needs: fixed in the latest commit.

@jyotshnayaparla-00 jyotshnayaparla-00 added this pull request to the merge queue Apr 3, 2026
Merged via the queue into main with commit 3d7046f Apr 3, 2026
1 check passed
@jyotshnayaparla-00 jyotshnayaparla-00 deleted the revert-60b70a96 branch April 3, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI cancel button no longer works

3 participants