fix: add header to prevent the creation of new users in proxy authentication#5892
Open
ArielLeyva wants to merge 2 commits intofilebrowser:masterfrom
Conversation
Member
|
@ArielLeyva thanks for this. Can we also make it clear that "Allow users to signup" doesn't apply to Proxy auth? |
…llow-users-to-signup-is-disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows a header to be sent in proxy authentication so that user creation can be prevented if the username sent by the proxy does not exist in the database.
The proxy can send the
X-Auth-No-Create-Userheader with the valuetrueto prevent the user from being created if it does not exist in the database; if the user does not exist, filebrowser authentication is not passed.The explanation of this behavior and the use of the
X-Auth-No-Create-Userheader was added to the documentation.Additional Information
Closes #3900
Checklist
Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.
masterbranch.