Merged
Conversation
Change-Id: Iaafad0f3b8707e862db6b7210bc2398e63d83396
Contributor
Author
|
@puf PTAL |
Contributor
|
lgtm on a code level. So I'm fine including this in 0.5.3. I don't like the approach though. In general I prefer seeing these things in code, where they are more discoverable and can be made to auto-complete (I'm not sure if that applies to scopes specifically, since those are inherently stringly typed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump to Version 0.5.3 and improve testing
Found out why Robolectric was not loading our resources (
string-arrayvsarray) so changed the test to now use the real resource loading code, which would have caught #290 and will prevent any regressions there.