Firestore Aggregate Count Implementation and Tests#659
Merged
tom-andersen merged 5 commits intomainfrom Apr 6, 2023
Merged
Conversation
dconeybe
suggested changes
Mar 29, 2023
Contributor
dconeybe
left a comment
There was a problem hiding this comment.
This basically all looks good to me. Nice job! Just a few very minor nits. Also, once the C++ SDK is merged then we should update this PR with the main branch and run the integration tests by adding the "tests requested: quick" label.
dconeybe
reviewed
Mar 29, 2023
# Conflicts: # docs/readme.md
dconeybe
suggested changes
Apr 5, 2023
Contributor
|
Everything LGTM. I'll give formal approval once the integration tests run and pass. @tom-andersen I had thought that adding the "Tests Requested: Quick" label would trigger the integration tests; however, that appears to have had no effect at all. Can you check with @cherylEnkidu or the FPL team to see how to trigger the integration tests? |
❌ Integration test FAILEDRequested by @firebase-workflow-trigger[bot] on commit bac6eab
|
dconeybe
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.