fix(rpfilter): use log denied packet type#1451
Open
TorontoMedia wants to merge 2 commits intofirewalld:mainfrom
Open
fix(rpfilter): use log denied packet type#1451TorontoMedia wants to merge 2 commits intofirewalld:mainfrom
TorontoMedia wants to merge 2 commits intofirewalld:mainfrom
Conversation
erig0
requested changes
May 30, 2025
| chain filter_PREROUTING { | ||
| icmpv6 type { nd-router-advert, nd-neighbor-solicit } accept | ||
| meta nfproto ipv6 fib saddr . mark . iif oif missing drop | ||
| meta nfproto ipv6 fib saddr . mark . iif oif missing meta pkttype multicast log prefix "rpfilter_DROP: " drop |
Collaborator
There was a problem hiding this comment.
Won't this cause it to drop only for multicast packets? Where as LogDenied is only about logging.
To support this, I think it would have to be two separate rules.
Collaborator
Author
There was a problem hiding this comment.
Correct, I apologize! I’ve now separated the rule configurations for cases where log denied is not equal to 'all', and created distinct test cases to specifically validate each scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1436