Add --add-richard-rule, rich rule for fancier folk#936
Open
fancyfolk500 wants to merge 1 commit intofirewalld:mainfrom
Hidden character warning
The head ref may contain hidden characters: "fancy/\ud83c\udfa9"
Open
Add --add-richard-rule, rich rule for fancier folk#936fancyfolk500 wants to merge 1 commit intofirewalld:mainfrom
fancyfolk500 wants to merge 1 commit intofirewalld:mainfrom
Conversation
Collaborator
|
Thanks for the new alias! The Richards of the world rejoice. Unfortunately I cannot merge it at this time due to missing requirements and testing.
|
Author
|
Hi Eric, I appreciate you reviewing my PR. I was really hoping to get this into RHEL 9, it's just a shame it takes so much work. I look forward to it being merged into RHEL 1099. Perhaps one of your maintainers can carry the SPIRIT of this PR forward. If you know any good maintainers who work on this, PLEASE forward it their way. Have a nice day 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using Firewalld for a while and it's been great! I have always thought it lacked a little something though. Some might call it flare, or spice. Something for the fanciest folks who need that 🎉 pizzazz 🪩 when they're at their day job.
I decided to implement
--add-richard-ruleas an alias for--add-rich-rulewhich I think fills this rather important need. I'm hoping it can be included in the next release of RHEL. Any feedback is welcome 😌For more info on my design, please see here.