Fix warnings and incorrect size in from raw parts#15
Merged
Conversation
`std::process` is only used if debug assertions aren't enabled, so we can either `#[cfg]` the import or scope it to where it is used. I chose the latter.
And this silences a warning.
`size` is in bytes, but the `Vec` is a `Vec<usize>`. This doesn't blow up in practice because `usize` doesn't have a destructor, but if it did, then we would have been running destructors on garbage, out-of-bounds memory! As reported in https://news.ycombinator.com/item?id=16183438 -- great catch!
tromey
approved these changes
Jan 19, 2018
Collaborator
tromey
left a comment
There was a problem hiding this comment.
Thanks. Looks good to me.
Owner
Author
|
Thanks! I'm going to push a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rs? @tromey