Merged
Conversation
Since Rust updated to LLVM6, the std library's sort gets better compiled code, and beats our sort.
…line paths The whole thing was getting inlined before, and this saves code size without sacrificing speed.
tromey
approved these changes
Feb 26, 2018
Collaborator
tromey
left a comment
There was a problem hiding this comment.
Thank you. I read this patch and it all seemed good to me, though at this point I don't understand as much of this code as I probably should.
I'm glad to see the custom quicksort removal. It's great that this isn't a problem any more, since that was always a mystery performance hack.
| } | ||
| } | ||
|
|
||
| /// An iterator returned by `Mappigns::by_original_location`. |
Owner
Author
|
Thanks for the review, @tromey :) Happy to walk through any of the code with you, if you think it would help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the subsequence sorting algorithmic improvements from https://mrale.ph/blog/2018/02/03/maybe-you-dont-need-rust-to-speed-up-your-js.html and we get an additional 3x speed up: