Skip to content

Added currencylayer provider#36

Merged
florianv merged 1 commit intoflorianv:masterfrom
pascal-hofmann:master
Jun 20, 2016
Merged

Added currencylayer provider#36
florianv merged 1 commit intoflorianv:masterfrom
pascal-hofmann:master

Conversation

@pascal-hofmann
Copy link
Copy Markdown
Contributor

No description provided.

@pascal-hofmann
Copy link
Copy Markdown
Contributor Author

The failing Travis CI build is related to CentralBankOfCzechRepublicProvider.

@florianv
Copy link
Copy Markdown
Owner

Hey @phofmann-trust, thanks for the PR.

Can you rebase to the current master please ?

@pascal-hofmann pascal-hofmann force-pushed the master branch 2 times, most recently from 54ebfec to da1c168 Compare June 11, 2016 05:47
@pascal-hofmann
Copy link
Copy Markdown
Contributor Author

@florianv Rebased and StyleCI complaints fixed.

Comment thread src/Provider/CurrencyLayerProvider.php Outdated
/*
* This file is part of Swap.
*
* (c) Pascal Hofmann <[email protected]>
Copy link
Copy Markdown
Owner

@florianv florianv Jun 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright should be:

/*
 * This file is part of Swap.
 *
 * (c) Florian Voutzinos <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

You can add your authorship on the files you created, but the project remains my property.

@pascal-hofmann
Copy link
Copy Markdown
Contributor Author

Copyright fixed.

@pascal-hofmann
Copy link
Copy Markdown
Contributor Author

Any update on this? Would be great to have this merged. 👍

@florianv florianv merged commit 6d17142 into florianv:master Jun 20, 2016
@florianv
Copy link
Copy Markdown
Owner

Thanks for your contribution @phofmann-trust !

@florianv
Copy link
Copy Markdown
Owner

This is now available in version 2.6.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants