Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Re-enable logging.#19756

Merged
godofredoc merged 5 commits intomasterfrom
reenable_logging
Jul 16, 2020
Merged

Re-enable logging.#19756
godofredoc merged 5 commits intomasterfrom
reenable_logging

Conversation

@godofredoc
Copy link
Copy Markdown
Contributor

Description

fuchsia_ctl was updated to support processing the logs as a stream
instead of keeping them in the process.

Related Issues

flutter/flutter#57273

Tests

I added the following tests:

N/A tests were added on fuchsia_ctl

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants